Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 816803003: Revert of skia: Add 'skia_unittests' test suite for this directory. (Closed)

Created:
5 years, 11 months ago by Marijn Kruisselbrink
Modified:
5 years, 11 months ago
CC:
chromium-reviews, bsalomon, reed1, robertphillips, sky, Derek Bruening, Timur Iskhodzhanov, cjhopman, navabi1, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of skia: Add 'skia_unittests' test suite for this directory. (patchset #12 id:220001 of https://codereview.chromium.org/815023003/) Reason for revert: Fails linking on the Mac GN builder: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/2094 duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in: obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o obj/skia/ext/skia.skia_utils_mac.o (and more similar issues) Original issue's description: > skia: Add 'skia_unittests' test suite for this directory. > > This should be a lightweight test suite that should allow a dev changing > something in skia/ext to test it much more quickly than having to build > all 'unit_tests' target just to run the tests from skia/ext. > > BUG=444058 > TEST=skia_unittests links and runs fine. > R=danakj@chromium.org,thakis@chromium.org > > Committed: https://crrev.com/c87c3d2d949f9ba4f17627dc023b303c75b7635f > Cr-Commit-Position: refs/heads/master@{#310310} TBR=danakj@chromium.org,thakis@chromium.org,glider@chromium.org,sky@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=444058 Committed: https://crrev.com/164a39b1806a6261868bc6b2103e24b543251669 Cr-Commit-Position: refs/heads/master@{#310314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -188 lines) Patch
M build/all.gyp View 9 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 3 chunks +17 lines, -0 lines 0 comments Download
M skia/BUILD.gn View 2 chunks +0 lines, -46 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 3 chunks +14 lines, -19 lines 0 comments Download
D skia/skia_tests.gyp View 1 chunk +0 lines, -65 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +1 line, -4 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 5 chunks +0 lines, -5 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +4 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +4 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 2 chunks +0 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +1 line, -3 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +5 lines, -10 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/valgrind/chrome_tests.py View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Marijn Kruisselbrink
Created Revert of skia: Add 'skia_unittests' test suite for this directory.
5 years, 11 months ago (2015-01-07 17:50:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816803003/1
5 years, 11 months ago (2015-01-07 17:50:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 17:52:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/164a39b1806a6261868bc6b2103e24b543251669 Cr-Commit-Position: refs/heads/master@{#310314}
5 years, 11 months ago (2015-01-07 17:52:56 UTC) #4
Alexander Potapenko
5 years, 11 months ago (2015-01-12 09:20:51 UTC) #5
Message was sent while issue was closed.
On 2015/01/07 17:52:56, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/164a39b1806a6261868bc6b2103e24b543251669
> Cr-Commit-Position: refs/heads/master@{#310314}

rslgtm

Powered by Google App Engine
This is Rietveld 408576698