SuggestionsStore unittests not using real time.

components/suggestions/suggestions_store.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/suggestions/suggestions_store.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/prefs/pref_service.h"
+#include "base/time/clock.h"

[Mathieu, 2014/12/18 20:05:28]

don't need to include clock.h here, it's in the .h

[gayane -on leave until 09-2017, 2014/12/18 21:06:49]

Done.

+#include "base/time/default_clock.h"
 #include "base/time/time.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/suggestions/suggestions_pref_names.h"
 
 namespace suggestions {
 
 SuggestionsStore::SuggestionsStore(PrefService* profile_prefs)
-    : pref_service_(profile_prefs) {
+    : pref_service_(profile_prefs),
+    clock_(new base::DefaultClock()) {
   DCHECK(profile_prefs);
 }
 
+SuggestionsStore::SuggestionsStore() {}
+
 SuggestionsStore::~SuggestionsStore() {}
 
+void SuggestionsStore::SetClockForTesting(scoped_ptr<base::Clock> test_clock) {
+  this->clock_ = test_clock.Pass();
+}
+
 bool SuggestionsStore::LoadSuggestions(SuggestionsProfile* suggestions) {
   DCHECK(suggestions);
 
   const std::string base64_suggestions_data =
       pref_service_->GetString(prefs::kSuggestionsData);
   if (base64_suggestions_data.empty()) {
     suggestions->Clear();
     return false;
   }
 
@@ skipping 20 matching lines @@
       StoreSuggestions(*suggestions);
     }
   }
 
   return true;
 }
 
 void SuggestionsStore::FilterExpiredSuggestions(
     SuggestionsProfile* suggestions) {
   SuggestionsProfile filtered_suggestions;
-  int64 now_usec = (base::Time::NowFromSystemTime() - base::Time::UnixEpoch())
+  int64 now_usec = (this->clock_->Now() - base::Time::UnixEpoch())
       .ToInternalValue();
 
   for (int i = 0; i < suggestions->suggestions_size(); ++i) {
     ChromeSuggestion* suggestion = suggestions->mutable_suggestions(i);
     if (!suggestion->has_expiry_ts() || suggestion->expiry_ts() > now_usec) {
       filtered_suggestions.add_suggestions()->Swap(suggestion);
     }
   }
   suggestions->Swap(&filtered_suggestions);
 }
@@ skipping 15 matching lines @@
 
 // static
 void SuggestionsStore::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterStringPref(
       prefs::kSuggestionsData, std::string(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 }
 
 }  // namespace suggestions