Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 816653002: Monomorphic and polymorphic ICs with cleared maps should not go megamorphic. (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Monomorphic and polymorphic ICs with cleared maps should not go megamorphic. BUG=v8:3663 TEST=cctest/test-heap/MonomorphicStaysMonomorphicAfterGC LOG=N Committed: https://crrev.com/9ffdae66e24b7d7a5aaa1699ed9302b6583e2aa6 Cr-Commit-Position: refs/heads/master@{#25882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -1 line) Patch
M src/ic/ic.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
Hi Michael, here is the fix we discussed. PTAL.
6 years ago (2014-12-18 12:38:01 UTC) #2
mvstanton
Seems pretty good! Love the tests. LGTM.
6 years ago (2014-12-18 12:44:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816653002/1
6 years ago (2014-12-18 12:46:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 13:09:43 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-18 18:05:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ffdae66e24b7d7a5aaa1699ed9302b6583e2aa6
Cr-Commit-Position: refs/heads/master@{#25882}

Powered by Google App Engine
This is Rietveld 408576698