Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Issue 816603002: Gallery: Register unload handler to 'pagehide' event. (Closed)

Created:
6 years ago by hirono
Modified:
6 years ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Register unload handler to 'pagehide' event. Previously the unload handler is assigned to window.unload, but the method is not called in packaged apps. BUG=441647 TEST=None Committed: https://crrev.com/372a9183889718b7c11eb63d08841c5ca2e43ac0 Cr-Commit-Position: refs/heads/master@{#308962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M ui/file_manager/gallery/js/gallery.js View 3 chunks +4 lines, -8 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hirono
PTAL the CL? Thanks!
6 years ago (2014-12-18 01:46:45 UTC) #2
yawano
On 2014/12/18 01:46:45, hirono wrote: > PTAL the CL? Thanks! lgtm. Thank you!
6 years ago (2014-12-18 07:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816603002/1
6 years ago (2014-12-18 07:04:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 07:17:21 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-18 07:18:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/372a9183889718b7c11eb63d08841c5ca2e43ac0
Cr-Commit-Position: refs/heads/master@{#308962}

Powered by Google App Engine
This is Rietveld 408576698