Cleanup: Remove a shadow variable in CPDF_TextPage::CloseTempLine().

Cleanup: Remove a shadow variable in CPDF_TextPage::CloseTempLine().

R=bo_xu@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/266052af454927fc2d8f4877a8c6d79bf8a2cd36

[Lei Zhang, 2014-12-18 00:58:20]

thestig@chromium.org changed reviewers:
+ bo_xu@foxitsoftware.com

[Bo Xu, 2014-12-18 01:13:49]

https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
File core/src/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
core/src/fpdftext/fpdf_text_int.cpp:1198: for (FX_INT32 i = 0; i <
str.GetLength(); i++) {
nit: may just use "int" to be consistent with the rest of the code

https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
core/src/fpdftext/fpdf_text_int.cpp:1204: count1 --;
count1--;

https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
core/src/fpdftext/fpdf_text_int.cpp:1460: for (FX_STRSIZE j = 0; j < nItems;
j++) {
nit: use i here

[Lei Zhang, 2014-12-18 03:40:38]

https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
File core/src/fpdftext/fpdf_text_int.cpp (right):

https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
core/src/fpdftext/fpdf_text_int.cpp:1198: for (FX_INT32 i = 0; i <
str.GetLength(); i++) {
On 2014/12/18 01:13:49, Bo Xu wrote:
> nit: may just use "int" to be consistent with the rest of the code

Done.

https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
core/src/fpdftext/fpdf_text_int.cpp:1204: count1 --;
On 2014/12/18 01:13:49, Bo Xu wrote:
> count1--;

Done.

https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
core/src/fpdftext/fpdf_text_int.cpp:1460: for (FX_STRSIZE j = 0; j < nItems;
j++) {
On 2014/12/18 01:13:49, Bo Xu wrote:
> nit: use i here

Done.

[Bo Xu, 2014-12-18 03:41:52]

On 2014/12/18 03:40:38, Lei Zhang wrote:
>
https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
> File core/src/fpdftext/fpdf_text_int.cpp (right):
> 
>
https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
> core/src/fpdftext/fpdf_text_int.cpp:1198: for (FX_INT32 i = 0; i <
> str.GetLength(); i++) {
> On 2014/12/18 01:13:49, Bo Xu wrote:
> > nit: may just use "int" to be consistent with the rest of the code
> 
> Done.
> 
>
https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
> core/src/fpdftext/fpdf_text_int.cpp:1204: count1 --;
> On 2014/12/18 01:13:49, Bo Xu wrote:
> > count1--;
> 
> Done.
> 
>
https://codereview.chromium.org/816593002/diff/1/core/src/fpdftext/fpdf_text_...
> core/src/fpdftext/fpdf_text_int.cpp:1460: for (FX_STRSIZE j = 0; j < nItems;
> j++) {
> On 2014/12/18 01:13:49, Bo Xu wrote:
> > nit: use i here
> 
> Done.

LGTM

[Lei Zhang, 2014-12-18 04:10:05]

Committed patchset #2 (id:20001) manually as
266052af454927fc2d8f4877a8c6d79bf8a2cd36 (presubmit successful).