Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/tools/roll/build_v8.patch

Issue 816543004: Update from https://crrev.com/308996 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/gles2_conform_support/egl/display.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/roll/build_v8.patch
diff --git a/mojo/tools/roll/build_v8.patch b/mojo/tools/roll/build_v8.patch
new file mode 100644
index 0000000000000000000000000000000000000000..5f37307dc3d3e29251c64b0e0b52f7929fe1c1ec
--- /dev/null
+++ b/mojo/tools/roll/build_v8.patch
@@ -0,0 +1,14 @@
+diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni
+index e4bbf46..d42babd 100644
+--- a/build/module_args/v8.gni
++++ b/build/module_args/v8.gni
+@@ -6,5 +6,7 @@ if (is_android) {
+ import("//build/config/android/config.gni")
+ }
+
+-v8_use_external_startup_data =
+- !((is_android && is_android_webview_build) || is_chromeos || is_win)
++# Many V8 users in mojo do not support external startup data for V8, so
++# we disable it. If enabled, special care should be taken to ensure the
++# appropriate startup data is correctly bundled for apps.
++v8_use_external_startup_data = false
« no previous file with comments | « gpu/gles2_conform_support/egl/display.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698