Update mojo shell so that --args-for can be used on android

shell/android/mojo_main.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "shell/android/mojo_main.h"
 
-#include "base/android/command_line_android.h"
 #include "base/android/java_handler_thread.h"
 #include "base/android/jni_android.h"
+#include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/at_exit.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "jni/MojoMain_jni.h"
 #include "mojo/application_manager/application_loader.h"
 #include "mojo/application_manager/application_manager.h"
 #include "mojo/application_manager/background_shell_application_loader.h"
 #include "services/gles2/gpu_impl.h"
 #include "services/native_viewport/native_viewport_impl.h"
 #include "shell/android/android_handler_loader.h"
 #include "shell/android/ui_application_loader_android.h"
+#include "shell/command_line_util.h"
 #include "shell/context.h"
 #include "shell/init.h"
 #include "ui/gl/gl_surface_egl.h"
 
 using base::LazyInstance;
 
 namespace mojo {
 namespace shell {
 
 namespace {
@@ skipping 63 matching lines @@
   // Android handler is bundled with the Mojo shell, because it uses the
   // MojoShell application as the JNI bridge to bootstrap execution of other
   // Android Mojo apps that need JNI.
   context->application_manager()->SetLoaderForURL(
       make_scoped_ptr(new BackgroundShellApplicationLoader(
           make_scoped_ptr(new AndroidHandlerLoader()), "android_handler",
           base::MessageLoop::TYPE_DEFAULT)),
       GURL("mojo:android_handler"));
 }
 
-void RunShell(std::vector<GURL> app_urls) {
+void StartShellOnShellThread() {
   Context* context = g_context.Pointer()->get();
   ConfigureAndroidServices(context);
   context->Init();
-  for (std::vector<GURL>::const_iterator it = app_urls.begin();
-       it != app_urls.end(); ++it) {
-    context->Run(*it);
-  }
+  RunCommandLineApps(context);
 }
 
 }  // namespace
 
 static void Init(JNIEnv* env,
                  jclass clazz,
                  jobject context,
                  jstring mojo_shell_path,
                  jobjectArray jparameters,
                  jstring j_local_apps_directory) {
   base::android::ScopedJavaLocalRef<jobject> scoped_context(env, context);
   base::android::InitApplicationContext(env, scoped_context);
 
-  base::android::InitNativeCommandLineFromJavaArray(env, jparameters);
-  base::FilePath mojo_shell_file_path(
+  std::vector<std::string> parameters;
+  parameters.push_back(
       base::android::ConvertJavaStringToUTF8(env, mojo_shell_path));
-  base::CommandLine::ForCurrentProcess()->SetProgram(mojo_shell_file_path);
+  base::android::AppendJavaStringArrayToStringVector(env, jparameters,
+                                                     &parameters);
+  CommandLine::Init(0, nullptr);
+  base::CommandLine::ForCurrentProcess()->InitFromArgv(parameters);
+
   InitializeLogging();
 
   // We want ~MessageLoop to happen prior to ~Context. Initializing
   // LazyInstances is akin to stack-allocating objects; their destructors
   // will be invoked first-in-last-out.
   Context* shell_context = new Context();
   shell_context->mojo_url_resolver()->SetLocalAppsPath(base::FilePath(
       base::android::ConvertJavaStringToUTF8(env, j_local_apps_directory)));
+  for (auto& args : parameters) {
+    ApplyApplicationArgs(shell_context, args);
+  }
+
   g_context.Get().reset(shell_context);
 
   g_java_message_loop.Get().reset(new base::MessageLoopForUI);
   base::MessageLoopForUI::current()->Start();
 
   // TODO(abarth): At which point should we switch to cross-platform
   // initialization?
 
   gfx::GLSurface::InitializeOneOff();
 }
 
-static void Start(JNIEnv* env, jclass clazz, jstring jurl) {
-  std::vector<GURL> app_urls;
+static jboolean Start(JNIEnv* env, jclass clazz) {
+  if (!base::CommandLine::ForCurrentProcess()->GetArgs().size()) {

[sky, 2014/12/17 16:44:04]

nit: no {}

[qsr, 2014/12/18 14:21:35]

Done.

+    return false;
+  }
+
 #if defined(MOJO_SHELL_DEBUG_URL)
-  app_urls.push_back(GURL(MOJO_SHELL_DEBUG_URL));
+  base::CommandLine::ForCurrentProcess()->AppendArg(MOJO_SHELL_DEBUG_URL);
   // Sleep for 5 seconds to give the debugger a chance to attach.
   sleep(5);
-#else
-  if (jurl)
-    app_urls.push_back(GURL(base::android::ConvertJavaStringToUTF8(env, jurl)));
 #endif
 
   g_shell_thread.Get().reset(
       new base::android::JavaHandlerThread("shell_thread"));
   g_shell_thread.Get()->Start();
   g_shell_thread.Get()->message_loop()->PostTask(
-      FROM_HERE, base::Bind(&RunShell, app_urls));
+      FROM_HERE, base::Bind(&StartShellOnShellThread));
+  return true;
+}
+
+static void AddApplicationURL(JNIEnv* env, jclass clazz, jstring jurl) {
+  base::CommandLine::ForCurrentProcess()->AppendArg(
+      base::android::ConvertJavaStringToUTF8(env, jurl));
 }
 
 bool RegisterMojoMain(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace shell
 }  // namespace mojo