Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 816463005: mojo HTMLViewer crash (Closed)

Created:
6 years ago by dtapuska
Modified:
6 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo HTMLViewer crash The viewer would crash because MojoMain was moved into a html_viewer namespace. The MojoMain should remain in the default namespace. BUG=444099 Committed: https://crrev.com/ccfd55115d9642d55e5346ae337bcb92f5f913a6 Cr-Commit-Position: refs/heads/master@{#309423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M mojo/services/html_viewer/html_viewer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
DaveMoore
lgtm
6 years ago (2014-12-19 23:53:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816463005/1
6 years ago (2014-12-20 00:07:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/31759)
6 years ago (2014-12-20 00:15:07 UTC) #6
pwestin(chromium)
On 2014/12/20 00:15:07, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-20 00:32:35 UTC) #8
Aaron Boodman
lgtm
6 years ago (2014-12-20 17:46:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816463005/1
6 years ago (2014-12-22 14:33:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 14:37:03 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-22 14:37:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccfd55115d9642d55e5346ae337bcb92f5f913a6
Cr-Commit-Position: refs/heads/master@{#309423}

Powered by Google App Engine
This is Rietveld 408576698