Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: cc/resources/tiling_set_raster_queue_required.h

Issue 816453008: cc: Split tiling set raster queues into all and required. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: todos Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CC_RESOURCES_TILING_SET_RASTER_QUEUE_REQUIRED_H_
6 #define CC_RESOURCES_TILING_SET_RASTER_QUEUE_REQUIRED_H_
7
8 #include "cc/base/cc_export.h"
9 #include "cc/resources/picture_layer_tiling_set.h"
10 #include "cc/resources/raster_tile_priority_queue.h"
11 #include "cc/resources/tile.h"
12 #include "cc/resources/tiling_set_raster_queue.h"
13
14 namespace cc {
15
16 // This queue only returns tiles that are required for either activation or
17 // draw, as specified by RasterTilePriorityQueue::Type passed in the
18 // constructor.
19 class CC_EXPORT TilingSetRasterQueueRequired : public TilingSetRasterQueue {
20 public:
21 TilingSetRasterQueueRequired(PictureLayerTilingSet* tiling_set,
22 RasterTilePriorityQueue::Type type);
23 ~TilingSetRasterQueueRequired() override;
24
25 Tile* Top() override;
26 const Tile* Top() const override;
27 void Pop() override;
28 bool IsEmpty() const override;
29
30 private:
31 class TilingIterator {
32 public:
33 TilingIterator();
34 explicit TilingIterator(PictureLayerTiling* tiling,
35 TilingData* tiling_data);
36 ~TilingIterator();
37
38 operator bool() const { return !!current_tile_; }
danakj 2015/01/08 23:24:41 should this be an operator comparablethingthatisnt
vmpstr 2015/01/09 20:21:41 Can you elaborate? I'm not sure I understand your
danakj 2015/01/09 20:28:22 I mean like this https://code.google.com/p/chromiu
vmpstr 2015/01/09 20:52:42 Hmm. Not really a fan from the clean code perspect
vmpstr 2015/01/10 01:44:55 After some discussion, I've decided to just go wit
39 const Tile* operator*() const { return current_tile_; }
40 Tile* operator*() { return current_tile_; }
41 TilingIterator& operator++();
42
43 private:
44 bool TileNeedsRaster(Tile* tile) const {
45 return tile->NeedsRaster() && !tiling_->IsTileOccluded(tile);
46 }
47
48 PictureLayerTiling* tiling_;
49 TilingData* tiling_data_;
50
51 Tile* current_tile_;
52 TilingData::Iterator visible_iterator_;
53 };
54
55 bool IsTileRequired(const Tile* tile) const;
56
57 TilingIterator iterator_;
58 RasterTilePriorityQueue::Type type_;
59 };
60
61 } // namespace cc
62
63 #endif // CC_RESOURCES_TILING_SET_RASTER_QUEUE_REQUIRED_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698