Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: src/compiler/raw-machine-assembler.h

Issue 816453005: [turbofan] Cleanup use of virtual, OVERRIDE, FINAL. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_RAW_MACHINE_ASSEMBLER_H_ 5 #ifndef V8_COMPILER_RAW_MACHINE_ASSEMBLER_H_
6 #define V8_COMPILER_RAW_MACHINE_ASSEMBLER_H_ 6 #define V8_COMPILER_RAW_MACHINE_ASSEMBLER_H_
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/compiler/common-operator.h" 10 #include "src/compiler/common-operator.h"
(...skipping 30 matching lines...) Expand all
41 bool used_; 41 bool used_;
42 bool bound_; 42 bool bound_;
43 friend class RawMachineAssembler; 43 friend class RawMachineAssembler;
44 DISALLOW_COPY_AND_ASSIGN(Label); 44 DISALLOW_COPY_AND_ASSIGN(Label);
45 }; 45 };
46 46
47 RawMachineAssembler(Graph* graph, MachineSignature* machine_sig, 47 RawMachineAssembler(Graph* graph, MachineSignature* machine_sig,
48 MachineType word = kMachPtr, 48 MachineType word = kMachPtr,
49 MachineOperatorBuilder::Flags flags = 49 MachineOperatorBuilder::Flags flags =
50 MachineOperatorBuilder::Flag::kNoFlags); 50 MachineOperatorBuilder::Flag::kNoFlags);
51 virtual ~RawMachineAssembler() {} 51 ~RawMachineAssembler() OVERRIDE {}
52 52
53 Isolate* isolate() const { return zone()->isolate(); } 53 Isolate* isolate() const { return zone()->isolate(); }
54 Zone* zone() const { return graph()->zone(); } 54 Zone* zone() const { return graph()->zone(); }
55 MachineOperatorBuilder* machine() { return &machine_; } 55 MachineOperatorBuilder* machine() { return &machine_; }
56 CommonOperatorBuilder* common() { return &common_; } 56 CommonOperatorBuilder* common() { return &common_; }
57 CallDescriptor* call_descriptor() const { return call_descriptor_; } 57 CallDescriptor* call_descriptor() const { return call_descriptor_; }
58 size_t parameter_count() const { return machine_sig_->parameter_count(); } 58 size_t parameter_count() const { return machine_sig_->parameter_count(); }
59 MachineSignature* machine_sig() const { return machine_sig_; } 59 MachineSignature* machine_sig() const { return machine_sig_; }
60 60
61 Node* UndefinedConstant() { 61 Node* UndefinedConstant() {
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 return NewNode(common()->Phi(type, 3), n1, n2, n3); 423 return NewNode(common()->Phi(type, 3), n1, n2, n3);
424 } 424 }
425 Node* Phi(MachineType type, Node* n1, Node* n2, Node* n3, Node* n4) { 425 Node* Phi(MachineType type, Node* n1, Node* n2, Node* n3, Node* n4) {
426 return NewNode(common()->Phi(type, 4), n1, n2, n3, n4); 426 return NewNode(common()->Phi(type, 4), n1, n2, n3, n4);
427 } 427 }
428 428
429 // MachineAssembler is invalid after export. 429 // MachineAssembler is invalid after export.
430 Schedule* Export(); 430 Schedule* Export();
431 431
432 protected: 432 protected:
433 virtual Node* MakeNode(const Operator* op, int input_count, Node** inputs, 433 Node* MakeNode(const Operator* op, int input_count, Node** inputs,
434 bool incomplete) FINAL; 434 bool incomplete) FINAL;
435 435
436 bool ScheduleValid() { return schedule_ != NULL; } 436 bool ScheduleValid() { return schedule_ != NULL; }
437 437
438 Schedule* schedule() { 438 Schedule* schedule() {
439 DCHECK(ScheduleValid()); 439 DCHECK(ScheduleValid());
440 return schedule_; 440 return schedule_;
441 } 441 }
442 442
443 private: 443 private:
444 BasicBlock* Use(Label* label); 444 BasicBlock* Use(Label* label);
(...skipping 10 matching lines...) Expand all
455 BasicBlock* current_block_; 455 BasicBlock* current_block_;
456 456
457 DISALLOW_COPY_AND_ASSIGN(RawMachineAssembler); 457 DISALLOW_COPY_AND_ASSIGN(RawMachineAssembler);
458 }; 458 };
459 459
460 } // namespace compiler 460 } // namespace compiler
461 } // namespace internal 461 } // namespace internal
462 } // namespace v8 462 } // namespace v8
463 463
464 #endif // V8_COMPILER_RAW_MACHINE_ASSEMBLER_H_ 464 #endif // V8_COMPILER_RAW_MACHINE_ASSEMBLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698