Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 816453005: [turbofan] Cleanup use of virtual, OVERRIDE, FINAL. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
CC:
v8-dev, tfarina
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cleanup use of virtual, OVERRIDE, FINAL. Following the Google/Chromium coding style wrt. virtual, OVERRIDE and FINAL specifications. TEST=unittests R=jochen@chromium.org Committed: https://crrev.com/1ec1f5957f69d0cdbfd4618c5dc50b1ad1524f90 Cr-Commit-Position: refs/heads/master@{#25924}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -127 lines) Patch
M src/compiler/ast-graph-builder.h View 4 chunks +10 lines, -10 lines 0 comments Download
M src/compiler/change-lowering.h View 1 chunk +2 lines, -2 lines 1 comment Download
M src/compiler/code-generator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/control-builders.h View 7 chunks +12 lines, -11 lines 0 comments Download
M src/compiler/gap-resolver.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/graph-builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/source-position.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/graph-unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-matchers-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 42 chunks +47 lines, -69 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
6 years ago (2014-12-22 13:45:00 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-22 13:45:10 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-22 13:46:16 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 1ec1f5957f69d0cdbfd4618c5dc50b1ad1524f90 (presubmit successful).
6 years ago (2014-12-22 13:48:18 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1ec1f5957f69d0cdbfd4618c5dc50b1ad1524f90 Cr-Commit-Position: refs/heads/master@{#25924}
6 years ago (2014-12-22 13:48:22 UTC) #5
tfarina
6 years ago (2014-12-22 18:29:45 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/816453005/diff/1/src/compiler/change-lowering.h
File src/compiler/change-lowering.h (right):

https://codereview.chromium.org/816453005/diff/1/src/compiler/change-lowering...
src/compiler/change-lowering.h:24: ~ChangeLowering() FINAL;
Out of curiosity, was this generated manually or using a script?

Powered by Google App Engine
This is Rietveld 408576698