Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 816453003: Replace [Default=Undefined] with per-spec syntax for AudioNode (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Raymond Toy
CC:
blink-reviews, Raymond Toy
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace [Default=Undefined] with per-spec syntax for AudioNode http://webaudio.github.io/web-audio-api/#the-audionode-interface This does not change observable behavior, as toInt32 in V8Binding.cpp returns 0 for undefined. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/modules/webaudio/AudioNode.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years ago (2014-12-17 14:48:38 UTC) #2
Raymond Toy
lgtm
6 years ago (2014-12-17 15:55:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816453003/1
6 years ago (2014-12-17 15:56:40 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 18:00:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187392

Powered by Google App Engine
This is Rietveld 408576698