appengine/chrome_infra_packages/cipd/__init__.py - Issue 816433004: cipd: registerPackage method implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/chrome_infra_packages/cipd/init.py

Issue 816433004: cipd: registerPackage method implementation. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from infra.libs.decorators.decorators import cached_property	5 from .api import PackageRepositoryApi

	6 from .impl import get_repo_service
	nodir 2014/12/30 22:54:00 You should probably import PackageInstanceSignatur You should probably import PackageInstanceSignature as well, since you can't use RepoService.register_package without it Vadim Sh. 2014/12/31 01:27:35 Removed get_repo_service instead. It is not used o Show quoted text On 2014/12/30 22:54:00, nodir wrote: > You should probably import PackageInstanceSignature as well, since you can't use > RepoService.register_package without it Removed get_repo_service instead. It is not used outside of the package yet. nodir 2015/01/02 19:13:03 Acknowledged. Show quoted text On 2014/12/31 01:27:35, Vadim Sh. wrote: > On 2014/12/30 22:54:00, nodir wrote: > > You should probably import PackageInstanceSignature as well, since you can't > use > > RepoService.register_package without it > > Removed get_repo_service instead. It is not used outside of the package yet. Acknowledged.
OLD	NEW