cipd: registerPackage method implementation.

appengine/chrome_infra_packages/cas/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Cloud Endpoints API for Content Addressable Storage."""
 
 import endpoints
 
 from protorpc import message_types
 from protorpc import messages
 from protorpc import remote
 
 from components import auth
 
 from . import impl
 
-# TODO(vadimsh): Improve authorization scheme.
 
 # This is used by endpoints indirectly.
 package = 'cipd'
 
 
 class BeginUploadResponse(messages.Message):
   class Status(messages.Enum):
     # New upload session has started.
     SUCCESS = 1
     # Such file is already uploaded to the store.
@@ skipping 54 matching lines @@
       hash_algo = messages.StringField(1, required=True),
       # Hex hash digest of a file client wants to upload.
       file_hash = messages.StringField(2, required=True))
 
   @auth.endpoints_method(
       BEGIN_UPLOAD_RESOURCE_CONTAINER,
       BeginUploadResponse,
       path='upload/{hash_algo}/{file_hash}',
       http_method='POST',
       name='beginUpload')
-  @auth.require(lambda: not auth.get_current_identity().is_anonymous)
+  @auth.require(auth.is_admin)
   def begin_upload(self, request):
     """Initiates an upload operation if file is missing.
 
     Once initiated the client is then responsible for uploading the file to
     temporary location (returned as 'upload_url') and finalizing the upload
     with call to 'finishUpload'.
 
     If file is already in the store, returns ALREADY_UPLOADED status.
+
+    This method is not intended to be used directly by all clients (only by
+    admins in case some files has to be injected into CAS store directly). Use
+    PackageRepositoryApi.register_package instead to initiate an upload of some
+    package and get upload_url and upload_session_id.
     """
     if not impl.is_supported_hash_algo(request.hash_algo):
       raise endpoints.BadRequestException('Unsupported hash algo')
     if not impl.is_valid_hash_digest(request.hash_algo, request.file_hash):
       raise endpoints.BadRequestException('Invalid hash digest format')
 
     service = impl.get_cas_service()
     if service is None:
       raise endpoints.InternalServerErrorException('Service is not configured')
 
@@ skipping 23 matching lines @@
       http_method='POST',
       name='finishUpload')
   @auth.require(lambda: not auth.get_current_identity().is_anonymous)
   def finish_upload(self, request):
     """Finishes pending upload or queries its status.
 
     Client should finalize Google Storage upload session first. Once GS upload
     is finalized and 'finishUpload' is called, the server starts hash
     verification. Uploading client will get 'VERIFYING' status response. It
     can continue polling on this method until server returns 'PUBLISHED' status.
+
+    upload_session_id implicitly authorizes the request.
     """
     service = impl.get_cas_service()
     if service is None:
       raise endpoints.InternalServerErrorException('Service is not configured')
 
     # Verify the signature if upload_session_id and grab the session. Broken
     # or expired signatures are treated in same way as missing upload sessions.
     # No need to provide more hits to the malicious caller.
     upload_session = service.fetch_upload_session(
         request.upload_session_id, auth.get_current_identity())
     if upload_session is None:
       return FinishUploadResponse(status=FinishUploadResponse.Status.MISSING)
 
     # Start object verification task if necessary, returns updated copy of
     # |upload_session| entity.
     upload_session = service.maybe_finish_upload(upload_session)
 
     response = FinishUploadResponse(
         status=_UPLOAD_STATUS_MAPPING[upload_session.status])
     if upload_session.status == impl.UploadSession.STATUS_ERROR:
       response.error_message = upload_session.error_message or 'Unknown error'
     return response