Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 816423004: Remove some dead code. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan, abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove some dead code. These methods have no callers. I also added a TODO to actually clear the font cache properly. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2f11ede505d4946321052761e4978740f81c3a54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 3 chunks +8 lines, -6 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-13 07:18:07 UTC) #3
esprehn
5 years, 11 months ago (2015-01-13 07:33:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f11ede505d4946321052761e4978740f81c3a54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698