Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1870)

Unified Diff: chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc

Issue 816403003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
diff --git a/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc b/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
index 8204bb253386995c53e7c66dae16d40c6e46aa0a..c3db3660a9eaac857145bbc38ed57a38fe4598b7 100644
--- a/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
+++ b/chrome/browser/nacl_host/test/gdb_debug_stub_browsertest.cc
@@ -19,7 +19,7 @@ class NaClGdbDebugStubTest : public PPAPINaClNewlibTest {
NaClGdbDebugStubTest() {
}
- void SetUpCommandLine(CommandLine* command_line) override;
+ void SetUpCommandLine(base::CommandLine* command_line) override;
void StartTestScript(base::ProcessHandle* test_process,
std::string test_name, int debug_stub_port);
@@ -27,7 +27,7 @@ class NaClGdbDebugStubTest : public PPAPINaClNewlibTest {
const std::string& test_name);
};
-void NaClGdbDebugStubTest::SetUpCommandLine(CommandLine* command_line) {
+void NaClGdbDebugStubTest::SetUpCommandLine(base::CommandLine* command_line) {
PPAPINaClNewlibTest::SetUpCommandLine(command_line);
command_line->AppendSwitch(switches::kEnableNaClDebug);
}
@@ -36,7 +36,7 @@ void NaClGdbDebugStubTest::StartTestScript(base::ProcessHandle* test_process,
std::string test_name,
int debug_stub_port) {
// We call python script to reuse GDB RSP protocol implementation.
- CommandLine cmd(base::FilePath(FILE_PATH_LITERAL("python")));
+ base::CommandLine cmd(base::FilePath(FILE_PATH_LITERAL("python")));
base::FilePath script;
PathService::Get(chrome::DIR_TEST_DATA, &script);
script = script.AppendASCII("nacl/debug_stub_browser_tests.py");
« no previous file with comments | « chrome/browser/metrics/variations/variations_service.cc ('k') | chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698