[WebCrypto] Cleanup in LoadTestKeys() in ecdh unit tests

content/test/data/webcrypto/ecdh.json

Index: content/test/data/webcrypto/ecdh.json
diff --git a/content/test/data/webcrypto/ecdh.json b/content/test/data/webcrypto/ecdh.json
index f51f7d103c206af7ffdfc349c005d0d0ec2eb9af..bcb5291ab58cc281a098a017a8881c2ec7b32ce6 100644
--- a/content/test/data/webcrypto/ecdh.json
+++ b/content/test/data/webcrypto/ecdh.json
@@ -149,7 +149,8 @@
     },
 
     "length_bits": 521,
-    "derived_bytes": "0117D54D84379D0FD385BE068455A77A5366AB534FF172AB0A121F37D180DCCD19607ABB0C41CB9F6F12B01303AC4A69DC2D1D05180181FD496D9769B46BFFEC3400"
+    "derived_bytes": "0117D54D84379D0FD385BE068455A77A5366AB534FF172AB0A121F37D180DCCD19607ABB0C41CB9F6F12B01303AC4A69DC2D1D05180181FD496D9769B46BFFEC3400",
+    "load_p521_test_keys": 1 // Special variable use by ecdh_unittest.cc::LoadTestKeys

[eroman, 2014/12/22 17:56:07]

(1) This should be a boolean not an integer.
(2) Call it something more specific, like:
    * valid_p521_keys

Or instead, can ModifyLoadTestKeys to scan through the list for a valid P521 key
(testing that curve is P521 and the expectation is success).

[Habib Virji, 2014/12/23 10:59:05]

Changed to boolean and change to more specific attribute. 

Only reason why i did not do second suggestion, was there are some error test
too related to P-521 in json file. It would have required me to stop on finding
first p-521, to avoid confusion which p-521 is being used, that's why relying on
existing test. 

   },
 
   // Same as above but with the public/private switched.