Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 816363003: Implement missing functionality for job based recompilation (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement missing functionality for job based recompilation BUG=v8:3608 R=bmeurer@chromium.org LOG=n Committed: https://crrev.com/88feffc2ab1a6782b79a7e78ff2d2839a5e50978 Cr-Commit-Position: refs/heads/master@{#25925}

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -81 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/optimizing-compiler-thread.h View 1 3 chunks +15 lines, -4 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 1 12 chunks +117 lines, -76 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
https://codereview.chromium.org/816363003/diff/1/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): https://codereview.chromium.org/816363003/diff/1/src/optimizing-compiler-thread.cc#newcode18 src/optimizing-compiler-thread.cc:18: static void DisposeOptimizedCompileJob(OptimizedCompileJob* job, Nit: use anonymous namespace instead ...
6 years ago (2014-12-22 13:10:49 UTC) #1
jochen (gone - plz use gerrit)
ptal
6 years ago (2014-12-22 13:20:37 UTC) #2
Benedikt Meurer
LGTM
6 years ago (2014-12-22 13:22:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816363003/10004
6 years ago (2014-12-22 13:23:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:10004)
6 years ago (2014-12-22 13:53:03 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-22 13:53:17 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/88feffc2ab1a6782b79a7e78ff2d2839a5e50978
Cr-Commit-Position: refs/heads/master@{#25925}

Powered by Google App Engine
This is Rietveld 408576698