Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 816363002: Make debugger raster window background black (Closed)

Created:
6 years ago by Kimmo Kinnunen
Modified:
6 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@wrap-render-target-uninit-read
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make debugger raster window background black Make debugger raster window background black. This helps to understand where the picture boundaries are. It is probably more common for pictures to have non-black background vs non-white background. This makes raster window similar to opengl window. Committed: https://skia.googlesource.com/skia/+/534c63ea911e4f7fbf89a2ba37237ea03a723fe9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M debugger/QT/SkRasterWidget.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
6 years ago (2014-12-22 09:49:27 UTC) #2
robertphillips
lgtm
6 years ago (2014-12-22 13:43:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816363002/1
6 years ago (2014-12-22 13:44:14 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-22 13:56:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/534c63ea911e4f7fbf89a2ba37237ea03a723fe9

Powered by Google App Engine
This is Rietveld 408576698