|
Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list.
An invisible function is hidden from stack traces, will not be enumerated
by mirrors, and cannot be directly invoked by mirrors. Note that private
classes remain accessible.
Fix a few internal dart:io functions that should be private.
Fix bug where mirrors would enumerate top-level invisible functions.
Mark observatory test that was using such private functions through
mirrors as failing.
BUG=http://dartbug.com/15274
R=hausner@google.com
Committed: https://code.google.com/p/dart/source/detail?r=43019
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+85 lines, -189 lines) |
Patch |
|
M |
runtime/bin/filter_patch.dart
|
View
|
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
runtime/bin/io_service_patch.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/socket_patch.dart
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/lib/mirrors.h
|
View
|
1
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
runtime/lib/mirrors.cc
|
View
|
1
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/object.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/vm/object.cc
|
View
|
|
2 chunks |
+0 lines, -93 lines |
0 comments
|
Download
|
|
M |
runtime/vm/parser.cc
|
View
|
|
6 chunks |
+16 lines, -12 lines |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/compiler/js_lib/io_patch.dart
|
View
|
|
2 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
|
M |
sdk/lib/io/data_transformer.dart
|
View
|
|
2 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
|
M |
sdk/lib/io/directory_impl.dart
|
View
|
|
8 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
sdk/lib/io/file_impl.dart
|
View
|
|
9 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
sdk/lib/io/file_system_entity.dart
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
sdk/lib/io/io_service.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
sdk/lib/io/link.dart
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
sdk/lib/io/secure_socket.dart
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
tests/lib/mirrors/invocation_fuzz_test.dart
|
View
|
|
1 chunk |
+0 lines, -17 lines |
0 comments
|
Download
|
|
M |
tests/standalone/standalone.status
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 4 (1 generated)
|