Enable beamforming in Swanky

content/renderer/media/media_stream_audio_processor.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_audio_processor.h"
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
@@ skipping 506 matching lines @@
     EnableAutomaticGainControl(audio_processing_.get());
 
   RecordProcessingState(AUDIO_PROCESSING_ENABLED);
 }
 
 void MediaStreamAudioProcessor::ConfigureBeamforming(webrtc::Config* config) {
   bool enabled = false;
   std::vector<webrtc::Point> geometry(1, webrtc::Point(0.f, 0.f, 0.f));
 #if defined(OS_CHROMEOS)
   const std::string board = base::SysInfo::GetLsbReleaseBoard();
   if (board == "peach_pi") {

[Pawel Osciak, 2015/01/16 02:26:21]

Could we have a generic commandline flag for beam forming and set it  via board
use in chromium commandline builder instead of in Chrome please?

Please see examples for IsBoard() in
https://chromium.googlesource.com/chromiumos/platform2/+/HEAD/libchromeos/chr....

[aluebs-chromium, 2015/01/21 19:18:21]

I would be happy to do it that way. My only concern is how to pass in the
geometry of the microphone array. Do you know how we could achieve that?

[Pawel Osciak, 2015/01/22 01:56:52]

Is there an API you can query to get it?

[aluebs-chromium, 2015/01/22 01:59:08]

No, they depend on the device and they are hard-coded here. But I am happy to
have a better solution.

     enabled = true;
     geometry.push_back(webrtc::Point(0.050f, 0.f, 0.f));
   } else if (board == "swanky") {
-    // TODO(aluebs): Verify beamforming works on Swanky and enable.
-    enabled = false;
+    enabled = true;
     geometry.push_back(webrtc::Point(0.052f, 0.f, 0.f));
   }
 #endif
   config->Set<webrtc::Beamforming>(new webrtc::Beamforming(enabled, geometry));
 }
 
 void MediaStreamAudioProcessor::InitializeCaptureFifo(
     const media::AudioParameters& input_format) {
   DCHECK(main_thread_checker_.CalledOnValidThread());
   DCHECK(input_format.IsValid());
@@ skipping 136 matching lines @@
                                               vad->stream_has_voice());
     base::subtle::Release_Store(&typing_detected_, detected);
   }
 
   // Return 0 if the volume hasn't been changed, and otherwise the new volume.
   return (agc->stream_analog_level() == volume) ?
       0 : agc->stream_analog_level();
 }
 
 }  // namespace content