Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import page_sets 5 import page_sets
6 from telemetry.web_perf import timeline_based_measurement 6 from telemetry.web_perf import timeline_based_measurement
7 from telemetry import benchmark 7 from telemetry import benchmark
8 8
9 9
10 @benchmark.Disabled('win') # crbug.com/416502 10 @benchmark.Disabled('win') # crbug.com/416502
11 class V8GarbageCollectionCases(benchmark.Benchmark): 11 class V8GarbageCollectionCases(benchmark.Benchmark):
12 """Measure V8 metrics on the garbage collection cases.""" 12 """Measure V8 metrics on the garbage collection cases."""
13 def CreateTimelineBasedMeasurementOptions(self): 13 def CreateTimelineBasedMeasurementOptions(self):
14 # TODO(ernstm): Remove v8-overhead when benchmark relevant v8 events become 14 # TODO(ernstm): Remove v8-overhead when benchmark relevant v8 events become
15 # available in the 'benchmark' category. 15 # available in the 'benchmark' category.
16 return timeline_based_measurement.Options(overhead_level='v8-overhead') 16 return timeline_based_measurement.Options(overhead_level='v8-overhead')
17 17
18 @classmethod
19 def Name(cls):
20 return 'v8.garbage_collection_cases'
21
18 page_set = page_sets.GarbageCollectionCasesPageSet 22 page_set = page_sets.GarbageCollectionCasesPageSet
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698