Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: tools/perf/benchmarks/skpicture_printer.py

Issue 816353008: [Telemetry] Explicitly define Name() method for all perf benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from measurements import skpicture_printer 5 from measurements import skpicture_printer
6 from telemetry import benchmark 6 from telemetry import benchmark
7 from telemetry.core import discover 7 from telemetry.core import discover
8 from telemetry.page import page_set 8 from telemetry.page import page_set
9 9
10 10
(...skipping 18 matching lines...) Expand all
29 help='Output directory for the SKP files') 29 help='Output directory for the SKP files')
30 @classmethod 30 @classmethod
31 def ProcessCommandLineArgs(cls, parser, args): 31 def ProcessCommandLineArgs(cls, parser, args):
32 if not args.page_set_name: 32 if not args.page_set_name:
33 parser.error('Please specify --page-set-name') 33 parser.error('Please specify --page-set-name')
34 if not args.page_set_base_dir: 34 if not args.page_set_base_dir:
35 parser.error('Please specify --page-set-base-dir') 35 parser.error('Please specify --page-set-base-dir')
36 if not args.skp_outdir: 36 if not args.skp_outdir:
37 parser.error('Please specify --skp-outdir') 37 parser.error('Please specify --skp-outdir')
38 38
39 @classmethod
40 def Name(cls):
41 return 'skpicture_printer'
42
39 def CreatePageTest(self, options): 43 def CreatePageTest(self, options):
40 return skpicture_printer.SkpicturePrinter(options.skp_outdir) 44 return skpicture_printer.SkpicturePrinter(options.skp_outdir)
41 45
42 def CreatePageSet(self, options): 46 def CreatePageSet(self, options):
43 page_set_class = _MatchPageSetName(options.page_set_name, 47 page_set_class = _MatchPageSetName(options.page_set_name,
44 options.page_set_base_dir) 48 options.page_set_base_dir)
45 return page_set_class() 49 return page_set_class()
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698