Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: PRESUBMIT.py

Issue 816293002: Fix dump_file_system compilation on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix PRESUBMIT.py script. Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | storage/browser/fileapi/dump_file_system.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 996 matching lines...) Expand 10 before | Expand all | Expand 10 after
1007 r"gl_helper_benchmark\.cc$", 1007 r"gl_helper_benchmark\.cc$",
1008 r"^courgette[\\\/]courgette_tool\.cc$", 1008 r"^courgette[\\\/]courgette_tool\.cc$",
1009 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$", 1009 r"^extensions[\\\/]renderer[\\\/]logging_native_handler\.cc$",
1010 r"^ipc[\\\/]ipc_logging\.cc$", 1010 r"^ipc[\\\/]ipc_logging\.cc$",
1011 r"^native_client_sdk[\\\/]", 1011 r"^native_client_sdk[\\\/]",
1012 r"^remoting[\\\/]base[\\\/]logging\.h$", 1012 r"^remoting[\\\/]base[\\\/]logging\.h$",
1013 r"^remoting[\\\/]host[\\\/].*", 1013 r"^remoting[\\\/]host[\\\/].*",
1014 r"^sandbox[\\\/]linux[\\\/].*", 1014 r"^sandbox[\\\/]linux[\\\/].*",
1015 r"^tools[\\\/]", 1015 r"^tools[\\\/]",
1016 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$", 1016 r"^ui[\\\/]aura[\\\/]bench[\\\/]bench_main\.cc$",
1017 r"^webkit[\\\/]browser[\\\/]fileapi[\\\/]" + 1017 r"^storage[\\\/]browser[\\\/]fileapi[\\\/]" +
1018 r"dump_file_system.cc$",)) 1018 r"dump_file_system.cc$",))
1019 source_file_filter = lambda x: input_api.FilterSourceFile( 1019 source_file_filter = lambda x: input_api.FilterSourceFile(
1020 x, white_list=(file_inclusion_pattern,), black_list=black_list) 1020 x, white_list=(file_inclusion_pattern,), black_list=black_list)
1021 1021
1022 log_info = [] 1022 log_info = []
1023 printf = [] 1023 printf = []
1024 1024
1025 for f in input_api.AffectedSourceFiles(source_file_filter): 1025 for f in input_api.AffectedSourceFiles(source_file_filter):
1026 contents = input_api.ReadFile(f, 'rb') 1026 contents = input_api.ReadFile(f, 'rb')
1027 if input_api.re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents): 1027 if input_api.re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents):
(...skipping 687 matching lines...) Expand 10 before | Expand all | Expand 10 after
1715 ] 1715 ]
1716 1716
1717 # Match things like path/aura/file.cc and path/file_aura.cc. 1717 # Match things like path/aura/file.cc and path/file_aura.cc.
1718 # Same for chromeos. 1718 # Same for chromeos.
1719 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files): 1719 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files):
1720 builders.extend([ 1720 builders.extend([
1721 'linux_chromium_chromeos_asan_rel_ng', 1721 'linux_chromium_chromeos_asan_rel_ng',
1722 ]) 1722 ])
1723 1723
1724 return GetDefaultTryConfigs(builders) 1724 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | storage/browser/fileapi/dump_file_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698