Fix dump_file_system compilation on Windows.

Fix dump_file_system compilation on Windows.

R=nhiroki@chromium.org

Committed: https://crrev.com/1425149c53486507772a11836a17e3f85ced90a9
Cr-Commit-Position: refs/heads/master@{#311022}

[Slava Chigrin, 2014-12-21 20:19:03]

https://codereview.chromium.org/816293002/diff/1/storage/browser/fileapi/dump...
File storage/browser/fileapi/dump_file_system.cc (right):

https://codereview.chromium.org/816293002/diff/1/storage/browser/fileapi/dump...
storage/browser/fileapi/dump_file_system.cc:54: const base::FilePath::CharType*
g_opt_fs_type = FILE_PATH_LITERAL("p");
Need to change variable type due to origin_dir.Append in line 73.

[kinuko, 2014-12-22 04:15:55]

lgtm

[Slava Chigrin, 2014-12-22 09:05:01]

The CQ bit was checked by vchigrin@yandex-team.ru

[commit-bot: I haz the power, 2014-12-22 09:05:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/816293002/1

[commit-bot: I haz the power, 2014-12-22 09:11:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-22 09:11:11]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Slava Chigrin, 2014-12-22 10:11:11]

On 2014/12/22 09:11:11, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Thank you for review, wanted to ask little question:
Presubmit job failing with message

** Presubmit ERRORS **
These files spam the console log with printf/fprintf:
  storage/browser/fileapi/dump_file_system.cc

but these changes do not add or modify anything, related to printf or fprintf.
Could you help, what should I do?

[nhiroki, 2014-12-25 08:44:59]

On 2014/12/22 10:11:11, Slava Chigrin wrote:
> On 2014/12/22 09:11:11, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux
> >
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> Thank you for review, wanted to ask little question:
> Presubmit job failing with message
> 
> ** Presubmit ERRORS **
> These files spam the console log with printf/fprintf:
>   storage/browser/fileapi/dump_file_system.cc
> 
> but these changes do not add or modify anything, related to printf or fprintf.
> Could you help, what should I do?

Probably you need to update the presubmit script:
https://code.google.com/p/chromium/codesearch#chromium/src/PRESUBMIT.py&q=%22...

The presubmit script checks if the modified files contain print functions to
avoid spamming the console. dump_file_system.cc was exempt from the check, but
the file-moving patch accidentally broke the rule.

[Slava Chigrin, 2014-12-25 09:31:28]

vchigrin@yandex-team.ru changed reviewers:
+ phajdan.jr@chromium.org

[Slava Chigrin, 2014-12-25 09:35:12]

Ah, I did not know that there is blacklist somewhere..
Updated PRESUBMIT.py and added  Paweł as OWNER of PRESUBUBMIT.py.
Thank you so much for help!

[nhiroki, 2014-12-26 07:44:33]

LGTM, thanks!

[Slava Chigrin, 2014-12-30 16:51:13]

vchigrin@yandex-team.ru changed reviewers:
+ jochen@chromium.org

[Paweł Hajdan Jr., 2015-01-07 16:51:16]

LGTM

[Slava Chigrin, 2015-01-12 07:17:56]

The CQ bit was checked by vchigrin@yandex-team.ru

[commit-bot: I haz the power, 2015-01-12 07:18:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/816293002/20001

[commit-bot: I haz the power, 2015-01-12 08:09:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-12 08:10:16]

Patchset 2 (id:??) landed as
https://crrev.com/1425149c53486507772a11836a17e3f85ced90a9
Cr-Commit-Position: refs/heads/master@{#311022}