Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 816273002: remove dead SK_SUPPORT_LEGACY_IMAGEDECODER_CHOOSER code (Closed)

Created:
6 years ago by reed2
Modified:
6 years ago
Reviewers:
scroggo, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove dead SK_SUPPORT_LEGACY_IMAGEDECODER_CHOOSER code BUG=skia: Committed: https://skia.googlesource.com/skia/+/2d73d80d68bc4b358eaa6da9f725d83f390af96a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -186 lines) Patch
M include/core/SkImageDecoder.h View 3 chunks +0 lines, -33 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 5 chunks +0 lines, -31 lines 0 comments Download
M src/images/SkImageDecoder_astc.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/images/SkImageDecoder_ktx.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/images/SkImageDecoder_libgif.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/images/SkImageDecoder_libico.cpp View 1 chunk +5 lines, -55 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/images/SkImageDecoder_libpng.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M src/images/SkImageDecoder_pkm.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
reed2
6 years ago (2014-12-21 18:47:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816273002/1
6 years ago (2014-12-21 18:47:53 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-21 18:47:54 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years ago (2014-12-22 00:47:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816273002/1
6 years ago (2014-12-22 15:02:54 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-22 15:02:55 UTC) #10
reed1
I presume these are gone for android ptal
6 years ago (2014-12-22 15:13:57 UTC) #12
scroggo
On 2014/12/22 15:13:57, reed1 wrote: > I presume these are gone for android > ptal ...
6 years ago (2014-12-22 15:21:08 UTC) #13
reed1
Do you want to unlegacy this API as is, or land this and create a ...
6 years ago (2014-12-22 15:22:59 UTC) #14
scroggo
On 2014/12/22 15:22:59, reed1 wrote: > Do you want to unlegacy this API as is, ...
6 years ago (2014-12-22 15:26:05 UTC) #15
scroggo
On 2014/12/22 15:26:05, scroggo wrote: > On 2014/12/22 15:22:59, reed1 wrote: > > Do you ...
6 years ago (2014-12-22 15:35:16 UTC) #16
commit-bot: I haz the power
6 years ago (2014-12-22 15:37:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2d73d80d68bc4b358eaa6da9f725d83f390af96a

Powered by Google App Engine
This is Rietveld 408576698