Update UI for WebStore bundle installs.

chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_install_dialog_view.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 48 matching lines @@
 // Width of the bullet column in BulletedView.
 const int kBulletWidth = 20;
 
 // Size of extension icon in top left of dialog.
 const int kIconSize = 64;
 
 // We offset the icon a little bit from the right edge of the dialog, to make it
 // align with the button below it.
 const int kIconOffset = 16;
 
+// Size of the icons of individual extensions for bundle installs.
+const int kSmallIconSize = 32;
+
+// Padding between extension icon and title for bundle installs.
+const int kSmallIconPadding = 6;
+
 // The dialog will resize based on its content, but this sets a maximum height
 // before overflowing a scrollbar.
 const int kDialogMaxHeight = 300;
 
 // Width of the left column of the dialog when the extension requests
 // permissions.
 const int kPermissionsLeftColumnWidth = 250;
 
 // Width of the left column of the dialog when the extension requests no
 // permissions.
 const int kNoPermissionsLeftColumnWidth = 200;
 
-// Width of the left column for bundle install prompts. There's only one column
-// in this case, so make it wider than normal.
-const int kBundleLeftColumnWidth = 300;
-
 // Width of the left column for external install prompts. The text is long in
 // this case, so make it wider than normal.
 const int kExternalInstallLeftColumnWidth = 350;
 
 void AddResourceIcon(const gfx::ImageSkia* skia_image, void* data) {
   views::View* parent = static_cast<views::View*>(data);
   views::ImageView* image_view = new views::ImageView();
   image_view->SetImage(*skia_image);
   parent->AddChildView(image_view);
 }
@@ skipping 23 matching lines @@
                         views::GridLayout::LEADING,
                         0,
                         views::GridLayout::USE_PREF,
                         0,  // No fixed width.
                         0);
   layout->StartRow(0, 0);
   layout->AddView(new views::Label(PrepareForDisplay(base::string16(), true)));
   layout->AddView(view);
 }
 
+IconedView::IconedView(views::View* view, const gfx::ImageSkia& image) {
+  views::GridLayout* layout = new views::GridLayout(this);
+  SetLayoutManager(layout);
+  views::ColumnSet* column_set = layout->AddColumnSet(0);
+  column_set->AddColumn(views::GridLayout::CENTER,
+                        views::GridLayout::LEADING,
+                        0,
+                        views::GridLayout::FIXED,
+                        kSmallIconSize,
+                        0);
+  column_set->AddPaddingColumn(0, kSmallIconPadding);
+  column_set->AddColumn(views::GridLayout::LEADING,
+                        views::GridLayout::CENTER,
+                        0,
+                        views::GridLayout::USE_PREF,
+                        0,  // No fixed width.
+                        0);
+  layout->StartRow(0, 0);
+
+  gfx::Size size(image.width(), image.height());
+  if (size.width() > kSmallIconSize || size.height() > kSmallIconSize)
+    size = gfx::Size(kSmallIconSize, kSmallIconSize);
+  views::ImageView* image_view = new views::ImageView;
+  image_view->SetImage(image);
+  image_view->SetImageSize(size);
+
+  layout->AddView(image_view);
+  layout->AddView(view);
+}
+
 void ShowExtensionInstallDialogImpl(
     ExtensionInstallPromptShowParams* show_params,
     ExtensionInstallPrompt::Delegate* delegate,
     scoped_refptr<ExtensionInstallPrompt::Prompt> prompt) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   ExtensionInstallDialogView* dialog =
       new ExtensionInstallDialogView(show_params->profile(),
                                      show_params->GetParentWebContents(),
                                      delegate,
                                      prompt);
@@ skipping 59 matching lines @@
   // | permissions_header |      |
   // +--------------------|      |
   // | permission1        |      |
   // +--------------------|      |
   // | permission2        |      |
   // +--------------------+------+
   int left_column_width =
       (prompt_->ShouldShowPermissions() + prompt_->GetRetainedFileCount()) > 0
           ? kPermissionsLeftColumnWidth
           : kNoPermissionsLeftColumnWidth;
-  if (is_bundle_install())
-    left_column_width = kBundleLeftColumnWidth;
   if (is_external_install())
     left_column_width = kExternalInstallLeftColumnWidth;
 
   scroll_view_ = new views::ScrollView();
   scroll_view_->set_hide_horizontal_scrollbar(true);
   AddChildView(scroll_view_);
 
   int column_set_id = 0;
   // Create the full scrollable view which will contain all the information
   // including the permissions.
   scrollable_ = new CustomScrollableView();
   views::GridLayout* layout = CreateLayout(
       scrollable_, left_column_width, column_set_id, false);
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
 
   scroll_view_->SetContents(scrollable_);
 
   int dialog_width = left_column_width + 2 * views::kPanelHorizMargin;
-  if (!is_bundle_install())
-    dialog_width += views::kPanelHorizMargin + kIconSize + kIconOffset;
+  dialog_width += views::kPanelHorizMargin + kIconSize + kIconOffset;
 
   if (prompt_->has_webstore_data()) {
     layout->StartRow(0, column_set_id);
     views::View* rating = new views::View();
     rating->SetLayoutManager(new views::BoxLayout(
         views::BoxLayout::kHorizontal, 0, 0, 0));
     layout->AddView(rating);
     prompt_->AppendRatingStars(AddResourceIcon, rating);
 
     const gfx::FontList& small_font_list =
@@ skipping 15 matching lines @@
     views::Link* store_link = new views::Link(
         l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_STORE_LINK));
     store_link->SetFontList(small_font_list);
     store_link->set_listener(this);
     layout->AddView(store_link);
   }
 
   if (is_bundle_install()) {
     BundleInstaller::ItemList items = prompt_->bundle()->GetItemsWithState(
         BundleInstaller::Item::STATE_PENDING);
-    for (size_t i = 0; i < items.size(); ++i) {
-      base::string16 extension_name =
-          base::UTF8ToUTF16(items[i].localized_name);
-      base::i18n::AdjustStringForLocaleDirection(&extension_name);
-      layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
+    layout->AddPaddingRow(0, views::kRelatedControlSmallVerticalSpacing);
+    for (const BundleInstaller::Item& item : items) {
       layout->StartRow(0, column_set_id);
-      views::Label* extension_label = new views::Label(
-          PrepareForDisplay(extension_name, true));
+      views::Label* extension_label =
+          new views::Label(item.GetNameForDisplay());
       extension_label->SetMultiLine(true);
       extension_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
-      extension_label->SizeToFit(left_column_width);
-      layout->AddView(extension_label);
+      extension_label->SizeToFit(
+          left_column_width - kSmallIconSize - kSmallIconPadding);
+      gfx::ImageSkia image = gfx::ImageSkia::CreateFrom1xBitmap(item.icon);
+      layout->AddView(new IconedView(extension_label, image));
     }
+    layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   }
 
   bool has_permissions =
       prompt_->GetPermissionCount(
           ExtensionInstallPrompt::PermissionsType::ALL_PERMISSIONS) > 0;
   if (prompt_->ShouldShowPermissions()) {
     AddPermissions(
         layout,
         rb,
         column_set_id,
@@ skipping 178 matching lines @@
   views::GridLayout* layout = views::GridLayout::CreatePanel(parent);
   parent->SetLayoutManager(layout);
 
   views::ColumnSet* column_set = layout->AddColumnSet(column_set_id);
   column_set->AddColumn(views::GridLayout::LEADING,
                         views::GridLayout::FILL,
                         0,  // no resizing
                         views::GridLayout::USE_PREF,
                         0,  // no fixed width
                         left_column_width);
-  if (!is_bundle_install()) {
-    column_set->AddPaddingColumn(0, views::kPanelHorizMargin);
-    column_set->AddColumn(views::GridLayout::TRAILING,
-                          views::GridLayout::LEADING,
-                          0,  // no resizing
-                          views::GridLayout::USE_PREF,
-                          0,  // no fixed width
-                          kIconSize);
-  }
+  column_set->AddPaddingColumn(0, views::kPanelHorizMargin);
+  column_set->AddColumn(views::GridLayout::TRAILING,
+                        views::GridLayout::LEADING,
+                        0,  // no resizing
+                        views::GridLayout::USE_PREF,
+                        0,  // no fixed width
+                        kIconSize);
 
   layout->StartRow(0, column_set_id);
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
 
   views::Label* heading = new views::Label(
       prompt_->GetHeading(), rb.GetFontList(ui::ResourceBundle::MediumFont));
   heading->SetMultiLine(true);
   heading->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   heading->SizeToFit(left_column_width);
   layout->AddView(heading);
 
-  if (!is_bundle_install()) {
-    // Scale down to icon size, but allow smaller icons (don't scale up).
-    const gfx::ImageSkia* image = prompt_->icon().ToImageSkia();
-    gfx::Size size(image->width(), image->height());
-    if (size.width() > kIconSize || size.height() > kIconSize)
-      size = gfx::Size(kIconSize, kIconSize);
-    views::ImageView* icon = new views::ImageView();
-    icon->SetImageSize(size);
-    icon->SetImage(*image);
-    icon->SetHorizontalAlignment(views::ImageView::CENTER);
-    icon->SetVerticalAlignment(views::ImageView::CENTER);
-    if (single_detail_row) {
-      layout->AddView(icon);
-    } else {
-      int icon_row_span = 1;
-      if (is_inline_install()) {
-        // Also span the rating, user_count and store_link rows.
-        icon_row_span = 4;
-      } else if (prompt_->ShouldShowPermissions()) {
-        size_t permission_count = prompt_->GetPermissionCount(
-            ExtensionInstallPrompt::PermissionsType::ALL_PERMISSIONS);
-        // Also span the permission header and each of the permission rows (all
-        // have a padding row above it). This also works for the 'no special
-        // permissions' case.
-        icon_row_span = 3 + permission_count * 2;
-      } else if (prompt_->GetRetainedFileCount()) {
-        // Also span the permission header and the retained files container.
-        icon_row_span = 4;
-      }
-      layout->AddView(icon, 1, icon_row_span);
+  // Scale down to icon size, but allow smaller icons (don't scale up).
+  const gfx::ImageSkia* image = prompt_->icon().ToImageSkia();
+  gfx::Size size(image->width(), image->height());
+  if (size.width() > kIconSize || size.height() > kIconSize)
+    size = gfx::Size(kIconSize, kIconSize);
+  views::ImageView* icon = new views::ImageView();
+  icon->SetImageSize(size);
+  icon->SetImage(*image);
+  icon->SetHorizontalAlignment(views::ImageView::CENTER);
+  icon->SetVerticalAlignment(views::ImageView::CENTER);
+  if (single_detail_row) {
+    layout->AddView(icon);
+  } else {
+    int icon_row_span = 1;
+    if (is_inline_install()) {
+      // Also span the rating, user_count and store_link rows.
+      icon_row_span = 4;
+    } else if (prompt_->ShouldShowPermissions()) {
+      size_t permission_count = prompt_->GetPermissionCount(
+          ExtensionInstallPrompt::PermissionsType::ALL_PERMISSIONS);
+      // Also span the permission header and each of the permission rows (all
+      // have a padding row above it). This also works for the 'no special
+      // permissions' case.
+      icon_row_span = 3 + permission_count * 2;
+    } else if (prompt_->GetRetainedFileCount()) {
+      // Also span the permission header and the retained files container.
+      icon_row_span = 4;
     }
+    layout->AddView(icon, 1, icon_row_span);
   }
+
   return layout;
 }
 
 void ExtensionInstallDialogView::ContentsChanged() {
   Layout();
 }
 
 int ExtensionInstallDialogView::GetDialogButtons() const {
   int buttons = prompt_->GetDialogButtons();
   // Simply having just an OK button is *not* supported. See comment on function
@@ skipping 281 matching lines @@
     slide_animation_.Hide();
   else
     slide_animation_.Show();
 }
 
 // static
 ExtensionInstallPrompt::ShowDialogCallback
 ExtensionInstallPrompt::GetDefaultShowDialogCallback() {
   return base::Bind(&ShowExtensionInstallDialogImpl);
 }