Update UI for WebStore bundle installs.

chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
 
 #include "base/auto_reset.h"
 #include "base/i18n/rtl.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/bundle_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #import "chrome/browser/ui/chrome_style.h"
+#include "chrome/browser/ui/cocoa/extensions/bundle_util.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/page_navigator.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_urls.h"
 #include "skia/ext/skia_utils_mac.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"
 #import "ui/base/cocoa/controls/hyperlink_button_cell.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 67 matching lines @@
 // Maximum height we will adjust controls to when trying to accomodate their
 // contents.
 const CGFloat kMaxControlHeight = 250;
 
 NSString* const kTitleKey = @"title";
 NSString* const kChildrenKey = @"children";
 NSString* const kCellAttributesKey = @"cellAttributes";
 NSString* const kPermissionsDetailIndex = @"permissionsDetailIndex";
 NSString* const kPermissionsDetailType = @"permissionsDetailType";
 
+// Computes the |control|'s desired height to fit its contents, constrained to
+// be kMaxControlHeight at most.
+CGFloat ComputeDesiredControlHeight(NSControl* control) {
+  NSRect rect = [control frame];
+  rect.size.height = kMaxControlHeight;
+  return [[control cell] cellSizeForBounds:rect].height;
+}
+
 // Adjust the |control|'s height so that its content is not clipped.
 // This also adds the change in height to the |totalOffset| and shifts the
 // control down by that amount.
 void OffsetControlVerticallyToFitContent(NSControl* control,
                                          CGFloat* totalOffset) {
   // Adjust the control's height so that its content is not clipped.
   NSRect currentRect = [control frame];
-  NSRect fitRect = currentRect;
-  fitRect.size.height = kMaxControlHeight;
-  CGFloat desiredHeight = [[control cell] cellSizeForBounds:fitRect].height;
+  CGFloat desiredHeight = ComputeDesiredControlHeight(control);
   CGFloat offset = desiredHeight - NSHeight(currentRect);
 
   [control setFrameSize:NSMakeSize(NSWidth(currentRect),
                                    NSHeight(currentRect) + offset)];
 
   *totalOffset += offset;
 
   // Move the control vertically by the new total offset.
   NSPoint origin = [control frame].origin;
   origin.y -= *totalOffset;
   [control setFrameOrigin:origin];
 }
 
+// Adjust the |view|'s height so that its subviews are not clipped.
+// This also adds the change in height to the |totalOffset| and shifts the
+// control down by that amount.
+void OffsetViewVerticallyToFitContent(NSView* view, CGFloat* totalOffset) {

[Alexei Svitkine (slow), 2015/04/23 16:47:39]

Nit: Since this is a C++ function, use hacker_style within it. Please update 
OffsetControlVerticallyToFitContent() as well which was not using the right
convention.

[Marc Treib, 2015/04/24 09:06:05]

Done, also for the other functions below.

+  // Adjust the view's height so that its subviews are not clipped.
+  CGFloat desiredHeight = 0;
+  for (NSView* subview in [view subviews]) {
+    int requiredHeight = NSMaxY([subview frame]);
+    if (requiredHeight > desiredHeight)
+      desiredHeight = requiredHeight;
+  }
+  NSRect currentRect = [view frame];
+  CGFloat offset = desiredHeight - NSHeight(currentRect);
+
+  [view setFrameSize:NSMakeSize(NSWidth(currentRect),
+                                NSHeight(currentRect) + offset)];
+
+  *totalOffset += offset;
+
+  // Move the view vertically by the new total offset.
+  NSPoint origin = [view frame].origin;
+  origin.y -= *totalOffset;
+  [view setFrameOrigin:origin];
+}
+
 // Gets the desired height of |outlineView|. Simply using the view's frame
 // doesn't work if an animation is pending.
 CGFloat GetDesiredOutlineViewHeight(NSOutlineView* outlineView) {
   CGFloat height = 0;
   for (NSInteger i = 0; i < [outlineView numberOfRows]; ++i)
     height += NSHeight([outlineView rectOfRow:i]);
   return height;
 }
 
 void OffsetOutlineViewVerticallyToFitContent(NSOutlineView* outlineView,
@@ skipping 125 matching lines @@
     prompt_->AppendRatingStars(AppendRatingStarsShim, self);
     [ratingCountField_ setStringValue:base::SysUTF16ToNSString(
         prompt_->GetRatingCount())];
     [userCountField_ setStringValue:base::SysUTF16ToNSString(
         prompt_->GetUserCount())];
     [[storeLinkButton_ cell] setUnderlineOnHover:YES];
     [[storeLinkButton_ cell] setTextColor:
         gfx::SkColorToCalibratedNSColor(chrome_style::GetLinkColor())];
   }
 
-  // The bundle install dialog has no icon.
-  if (![self isBundleInstall])
-    [iconView_ setImage:prompt_->icon().ToNSImage()];
+  [iconView_ setImage:prompt_->icon().ToNSImage()];
 
   // The dialog is laid out in the NIB exactly how we want it assuming that
   // each label fits on one line. However, for each label, we want to allow
   // wrapping onto multiple lines. So we accumulate an offset by measuring how
   // big each label wants to be, and comparing it to how big it actually is.
   // Then we shift each label down and resize by the appropriate amount, then
   // finally resize the window.
   CGFloat totalOffset = 0.0;
 
   OffsetControlVerticallyToFitContent(titleField_, &totalOffset);
@@ skipping 16 matching lines @@
         NSMaxX(okButtonRect) - NSWidth(cancelButtonRect);
     [cancelButton_ setFrame:cancelButtonRect];
   }
   buttonDelta = [GTMUILocalizerAndLayoutTweaker sizeToFitView:cancelButton_];
   if (buttonDelta.width) {
     [cancelButton_ setFrame:NSOffsetRect([cancelButton_ frame],
                                          -buttonDelta.width, 0)];
   }
 
   if ([self isBundleInstall]) {
-    // We display the list of extension names as a simple text string, seperated
-    // by newlines.
     BundleInstaller::ItemList items = prompt_->bundle()->GetItemsWithState(
         BundleInstaller::Item::STATE_PENDING);
+    PopulateBundleItemsList(items, itemsField_);
 
-    NSMutableString* joinedItems = [NSMutableString string];
-    for (size_t i = 0; i < items.size(); ++i) {
-      if (i > 0)
-        [joinedItems appendString:@"\n"];
-      [joinedItems appendString:base::SysUTF16ToNSString(
-          items[i].GetNameForDisplay())];
-    }
-    [itemsField_ setStringValue:joinedItems];
-
-    // Adjust the controls to fit the list of extensions.
-    OffsetControlVerticallyToFitContent(itemsField_, &totalOffset);
+    // Adjust the view to fit the list of extensions.
+    OffsetViewVerticallyToFitContent(itemsField_, &totalOffset);
   }
 
   // If there are any warnings, retained devices or retained files, then we
   // have to do some special layout.
   if (prompt_->ShouldShowPermissions() || prompt_->GetRetainedFileCount() > 0) {
     NSSize spacing = [outlineView_ intercellSpacing];
     spacing.width += 2;
     spacing.height += 2;
     [outlineView_ setIntercellSpacing:spacing];
     [[[[outlineView_ tableColumns] objectAtIndex:0] dataCell] setWraps:YES];
@@ skipping 476 matching lines @@
 }
 
 - (void)accessibilityPerformAction:(NSString*)action {
   if ([action isEqualToString:NSAccessibilityPressAction])
     [self handleLinkClicked];
   else
     [super accessibilityPerformAction:action];
 }
 
 @end