Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Issue 816193003: Add a new audio constraint, 'googHotword', that requests the hotword input (Closed)

Created:
5 years, 12 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 11 months ago
Reviewers:
rpetterson, DaleCurtis
CC:
chromium-reviews, skanuj+watch_chromium.org, sadrul, posciak+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, stevenjb+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, jam, darin-cc_chromium.org, rlp+watch_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, oshima+watch_chromium.org, kalyank, Jered, donnd+watch_chromium.org, mcasas+watch_chromium.org, chromium-apps-reviews_chromium.org, David Black, samarth+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kmadhusu+watch_chromium.org, wjia+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new audio constraint, 'googHotword', that requests the hotword input stream where available. BUG=403138 Committed: https://crrev.com/ee0205db24387b76fda082b8506f73e70288b320 Cr-Commit-Position: refs/heads/master@{#310171}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 2

Patch Set 3 : Add test. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M content/browser/renderer_host/media/media_stream_manager.cc View 3 chunks +25 lines, -0 lines 0 comments Download
M content/common/media/media_stream_options.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/media/media_stream_options.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
Anand Mistry (off Chromium)
5 years, 11 months ago (2015-01-02 00:46:26 UTC) #2
DaleCurtis
https://codereview.chromium.org/816193003/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/816193003/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc#newcode146 content/browser/renderer_host/media/media_stream_manager.cc:146: chromeos::CrasAudioHandler::Get()->GetAudioDevices(&devices); Is this something you want to check every ...
5 years, 11 months ago (2015-01-05 22:57:53 UTC) #3
rpetterson
I defer to Dale on this CL but have no issues with it.
5 years, 11 months ago (2015-01-06 00:14:48 UTC) #4
Anand Mistry (off Chromium)
https://codereview.chromium.org/816193003/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/816193003/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc#newcode146 content/browser/renderer_host/media/media_stream_manager.cc:146: chromeos::CrasAudioHandler::Get()->GetAudioDevices(&devices); On 2015/01/05 22:57:52, DaleCurtis wrote: > Is this ...
5 years, 11 months ago (2015-01-06 02:02:40 UTC) #5
DaleCurtis
Great, I see that now. Can you add a unittest to MediaStreamConstraintsUtilTest as well as ...
5 years, 11 months ago (2015-01-06 02:37:18 UTC) #6
Anand Mistry (off Chromium)
On 2015/01/06 02:37:18, DaleCurtis wrote: > Great, I see that now. Can you add a ...
5 years, 11 months ago (2015-01-06 06:35:38 UTC) #7
DaleCurtis
lgtm
5 years, 11 months ago (2015-01-06 19:04:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816193003/60001
5 years, 11 months ago (2015-01-06 22:43:58 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-06 23:36:16 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 23:36:58 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ee0205db24387b76fda082b8506f73e70288b320
Cr-Commit-Position: refs/heads/master@{#310171}

Powered by Google App Engine
This is Rietveld 408576698