Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 816193002: cc: Remove auto use with smart pointers. (Closed)

Created:
6 years ago by vmpstr
Modified:
6 years ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove auto use with smart pointers. This patch removes cc uses of auto with smart pointers. This ensures that it's explicit and clear what type of smart pointer is being used. I think it's better to do this now before this is used as a precedent for propagating this type of auto use. R=danakj Committed: https://crrev.com/39046bbd1a81bccaa8f3a21166d0ba8b7e050117 Cr-Commit-Position: refs/heads/master@{#309363}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -33 lines) Patch
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set_unittest.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 16 chunks +32 lines, -24 lines 0 comments Download
M cc/test/test_context_provider.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
PTAL. I don't know if we want to do this or keep it as is ...
6 years ago (2014-12-20 08:57:13 UTC) #1
danakj
lgtm
6 years ago (2014-12-20 21:07:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816193002/20001
6 years ago (2014-12-20 21:07:49 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-20 21:59:12 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-20 22:00:08 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39046bbd1a81bccaa8f3a21166d0ba8b7e050117
Cr-Commit-Position: refs/heads/master@{#309363}

Powered by Google App Engine
This is Rietveld 408576698