Greatly clean up depot_tools handling of git binaries, add bleeding edge support for 1.9.5

Greatly clean up depot_tools handling of git binaries, add bleeding edge support for 1.9.5

R=agable@chromium.org, friedman@chromium.org, mmoss@chromium.org, szager@chromium.org, vadimsh@chromium.org
BUG=

[iannucci, 2014-12-20 01:11:45]

On 2014/12/20 01:08:22, iannucci wrote:

I added everyone in the hopes of getting a review on this tonight. PTAL, it's
not as scary as it looks, and is needed for the git 1.9.5 rollout.

[iannucci, 2014-12-20 01:14:13]

https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
File bootstrap/win/win_tools.bat (left):

https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
bootstrap/win/win_tools.bat:90: :GIT_1852_CHECK
I removed HEAD support for ancient versions. They're at best confusing, and
likely dangerous. Our infrastructure assumes 1.9+ everywhere these days.

https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
bootstrap/win/win_tools.bat:149: call "%WIN_TOOLS_ROOT_DIR%\git.bat" config
--system core.filemode false
moved this down a block. These were causing the "system cannot file the file
specified" errors when you first clone gclient. Now they're run after the batch
files exist (amazing!)

[friedman1, 2014-12-20 01:14:45]

friedman@google.com changed reviewers:
+ friedman@google.com

[friedman1, 2014-12-20 01:14:45]

https://codereview.chromium.org/816173002/diff/1/bootstrap/win/win_tools.bat
File bootstrap/win/win_tools.bat (right):

https://codereview.chromium.org/816173002/diff/1/bootstrap/win/win_tools.bat#...
bootstrap/win/win_tools.bat:61: set GIT_VERSION=1.9.5.chromium.5
Don't we want to use >=1.9.5 for everything?

[friedman1, 2014-12-20 01:15:33]

lgtm

[iannucci, 2014-12-20 01:16:04]

On 2014/12/20 01:14:45, friedman1 wrote:
> https://codereview.chromium.org/816173002/diff/1/bootstrap/win/win_tools.bat
> File bootstrap/win/win_tools.bat (right):
> 
>
https://codereview.chromium.org/816173002/diff/1/bootstrap/win/win_tools.bat#...
> bootstrap/win/win_tools.bat:61: set GIT_VERSION=1.9.5.chromium.5
> Don't we want to use >=1.9.5 for everything?

Yes, I'll change the non-bleeding version next, but I wanted that change to be
isolated so the rollback (if needed) would be small and obvious.

[iannucci, 2014-12-20 01:18:35]

iannucci@chromium.org changed reviewers:
+ pgervais@chromium.org

[pgervais, 2014-12-20 01:29:38]

lgtm

[M-A Ruel, 2014-12-20 01:35:21]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2014-12-20 01:35:22]

lgtm

https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
File bootstrap/win/win_tools.bat (right):

https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
bootstrap/win/win_tools.bat:36: echo Installing python 2.7.6...
It'd be good to rip old installs, users are confused by that.

https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
bootstrap/win/win_tools.bat:73: rmdir /s /q "%%i"
Nobody uses rmdir, rd is the cool alias. :)

[iannucci, 2014-12-20 01:37:12]

On 2014/12/20 01:35:22, M-A Ruel wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
> File bootstrap/win/win_tools.bat (right):
> 
>
https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
> bootstrap/win/win_tools.bat:36: echo Installing python 2.7.6...
> It'd be good to rip old installs, users are confused by that.
> 

I think the real plan for this stuff should be to get vadim's cipd thingy and
then all this batch crap can dieeee.

>
https://chromiumcodereview.appspot.com/816173002/diff/1/bootstrap/win/win_too...
> bootstrap/win/win_tools.bat:73: rmdir /s /q "%%i"
> Nobody uses rmdir, rd is the cool alias. :)

;D

[agable, 2014-12-20 01:40:31]

lgtm

[iannucci, 2014-12-20 01:46:00]

For some reason git-cl-dcommit horked on me and didn't close the issue. This is
committed as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/50df5e236b64e1...

[mmoss, 2014-12-20 01:47:41]

mmoss@google.com changed reviewers:
+ mmoss@google.com

[mmoss, 2014-12-20 01:47:42]

lgtm