Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 816153002: Transform font size to user space for valid text size comparison. (Closed)

Created:
6 years ago by Bo Xu
Modified:
6 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Transform font size to user space for valid text size comparison. BUG=438441 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a09d50d09259bd90c865e92026a69f5434678e71

Patch Set 1 #

Total comments: 1

Patch Set 2 : space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M core/src/fpdftext/fpdf_text_int.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bo Xu
Hi Lei, a transformation was missed here, please take a look.
6 years ago (2014-12-20 00:16:28 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/816153002/diff/1/core/src/fpdftext/fpdf_text_int.cpp File core/src/fpdftext/fpdf_text_int.cpp (right): https://codereview.chromium.org/816153002/diff/1/core/src/fpdftext/fpdf_text_int.cpp#newcode1847 core/src/fpdftext/fpdf_text_int.cpp:1847: FX_FLOAT threshold = charinfo.m_Matrix.TransformXDistance((FX_FLOAT)TEXT_CHARRATIO_GAPDELTA*pTextObj->GetFontSize()); nit: add spaces around ...
6 years ago (2014-12-20 00:55:27 UTC) #3
Bo Xu
6 years ago (2014-12-20 00:58:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a09d50d09259bd90c865e92026a69f5434678e71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698