Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 816143002: Don't use ProfileIOData in PrintingMessageFilter. (Closed)

Created:
6 years ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use ProfileIOData in PrintingMessageFilter. PrintingMessageFilter does not know if ProfileIOData is destroyed. Instead of ProfileIOData filter can create onw BooleanPrefMember. BUG=428829 Committed: https://crrev.com/0ee426d04d2e114aefc61842810c07959b9da5d5 Cr-Commit-Position: refs/heads/master@{#309467}

Patch Set 1 #

Patch Set 2 : Sun Dec 21 12:32:01 PST 2014 #

Patch Set 3 : Sun Dec 21 13:25:55 PST 2014 #

Patch Set 4 : Mon Dec 22 12:45:15 PST 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/browser/printing/printing_message_filter.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Vitaly Buka (NO REVIEWS)
6 years ago (2014-12-21 20:46:23 UTC) #2
Vitaly Buka (NO REVIEWS)
6 years ago (2014-12-22 20:50:15 UTC) #5
Aleksey Shlyapnikov
lgtm
6 years ago (2014-12-22 20:50:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816143002/60001
6 years ago (2014-12-22 20:57:19 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-22 21:49:49 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-22 21:50:30 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0ee426d04d2e114aefc61842810c07959b9da5d5
Cr-Commit-Position: refs/heads/master@{#309467}

Powered by Google App Engine
This is Rietveld 408576698