Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: runtime/vm/profiler.cc

Issue 816123002: MemorySanitizer support. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/native_entry.cc ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler.cc
===================================================================
--- runtime/vm/profiler.cc (revision 42458)
+++ runtime/vm/profiler.cc (working copy)
@@ -2,6 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+#include "platform/memory_sanitizer.h"
#include "platform/utils.h"
#include "vm/allocation.h"
@@ -1934,7 +1935,10 @@
uword* CallerFP(uword* fp) const {
ASSERT(fp != NULL);
- return reinterpret_cast<uword*>(*(fp + kSavedCallerFpSlotFromFp));
+ uword* caller_fp_ptr = fp + kSavedCallerFpSlotFromFp;
+ // This may actually be uninitialized, by design (see class comment above).
+ MSAN_UNPOISON(caller_fp_ptr, kWordSize);
+ return reinterpret_cast<uword*>(*caller_fp_ptr);
}
bool ValidFramePointer(uword* fp) const {
« no previous file with comments | « runtime/vm/native_entry.cc ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698