pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart - Issue 816113005: Revert "dart2js OldEmitter: inline FinishClasses."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

Issue 816113005: Revert "dart2js OldEmitter: inline FinishClasses." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

index 3096ff76f7413b5267a04ecf3c949aa4d7f32294..d396698a13bcffad940a4eb777cb854400e639c3 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

@@ -286,7 +286,7 @@ class NsmEmitter extends CodeEmitterHelper {

var type = 0;

if (useDiffEncoding) {

statements.add(js.statement('''{

- var objectClassObject = processedClasses.collected[#objectClass],

+ var objectClassObject = collectedClasses[#objectClass],

shortNames = #diffEncoding.split(","),

nameNumber = 0,

diffEncodedString = shortNames[0],

@@ -331,7 +331,7 @@ class NsmEmitter extends CodeEmitterHelper {

Iterable<String> longs = trivialNsmHandlers.map((selector) =>

selector.invocationMirrorMemberName);

statements.add(js.statement(

- 'var objectClassObject = processedClasses.collected[#objectClass],'

+ 'var objectClassObject = collectedClasses[#objectClass],'

' shortNames = #diffEncoding.split(",")',

{'objectClass': js.string(namer.getNameOfClass(objectClass)),

'diffEncoding': js.string('$diffEncoding')}));