Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart

Issue 816113005: Revert "dart2js OldEmitter: inline FinishClasses." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 class ClassEmitter extends CodeEmitterHelper { 7 class ClassEmitter extends CodeEmitterHelper {
8 8
9 ClassStubGenerator get _stubGenerator => 9 ClassStubGenerator get _stubGenerator =>
10 new ClassStubGenerator(compiler, namer, backend); 10 new ClassStubGenerator(compiler, namer, backend);
11 11
12 /** 12 /**
13 * Documentation wanted -- johnniwinther 13 * Documentation wanted -- johnniwinther
14 * 14 *
15 * Invariant: [classElement] must be a declaration element. 15 * Invariant: [classElement] must be a declaration element.
16 */ 16 */
17 void generateClass(ClassElement classElement, 17 void generateClass(ClassElement classElement,
18 ClassBuilder properties, 18 ClassBuilder properties,
19 Map<String, jsAst.Expression> additionalProperties) { 19 Map<String, jsAst.Expression> additionalProperties) {
20 final onlyForRti = 20 final onlyForRti =
21 emitter.typeTestRegistry.rtiNeededClasses.contains(classElement); 21 emitter.typeTestRegistry.rtiNeededClasses.contains(classElement);
22 22
23 assert(invariant(classElement, classElement.isDeclaration)); 23 assert(invariant(classElement, classElement.isDeclaration));
24 assert(invariant(classElement, !classElement.isNative || onlyForRti)); 24 assert(invariant(classElement, !classElement.isNative || onlyForRti));
25 25
26 emitter.needsClassSupport = true; 26 emitter.needsDefineClass = true;
27 String className = namer.getNameOfClass(classElement); 27 String className = namer.getNameOfClass(classElement);
28 28
29 ClassElement superclass = classElement.superclass; 29 ClassElement superclass = classElement.superclass;
30 String superName = ""; 30 String superName = "";
31 if (superclass != null) { 31 if (superclass != null) {
32 superName = namer.getNameOfClass(superclass); 32 superName = namer.getNameOfClass(superclass);
33 } 33 }
34 34
35 if (classElement.isMixinApplication) { 35 if (classElement.isMixinApplication) {
36 String mixinName = namer.getNameOfClass(computeMixinClass(classElement)); 36 String mixinName = namer.getNameOfClass(computeMixinClass(classElement));
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
594 js(r'this.$builtinTypeInfo && this.$builtinTypeInfo[#]', index); 594 js(r'this.$builtinTypeInfo && this.$builtinTypeInfo[#]', index);
595 } 595 }
596 jsAst.Expression convertRtiToRuntimeType = emitter 596 jsAst.Expression convertRtiToRuntimeType = emitter
597 .staticFunctionAccess(backend.findHelper('convertRtiToRuntimeType')); 597 .staticFunctionAccess(backend.findHelper('convertRtiToRuntimeType'));
598 compiler.dumpInfoTask.registerElementAst(element, 598 compiler.dumpInfoTask.registerElementAst(element,
599 builder.addProperty(name, 599 builder.addProperty(name,
600 js('function () { return #(#) }', 600 js('function () { return #(#) }',
601 [convertRtiToRuntimeType, computeTypeVariable]))); 601 [convertRtiToRuntimeType, computeTypeVariable])));
602 } 602 }
603 } 603 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_backend/native_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698