mojo/public/tools/bindings/generators/mojom_dart_generator.py - Issue 816113004: Dart: Adds a content handler and a test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_dart_generator.py

Issue 816113004: Dart: Adds a content handler and a test. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Address comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/generators/mojom_dart_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_dart_generator.py b/mojo/public/tools/bindings/generators/mojom_dart_generator.py

index 893e66555a98be03140c35d7900028dca22ac88a..9862943cb4f6a98f0e8dbe2d6b6da447158fa156 100644

--- a/mojo/public/tools/bindings/generators/mojom_dart_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_dart_generator.py

@@ -121,8 +121,8 @@ _spec_to_encode_method = {

def GetDartType(kind):

if kind.imported_from:

- return kind.imported_from["unique_name"] + "." + kind.name

- return kind.name

+ return kind.imported_from["unique_name"] + "." + GetNameForElement(kind)

+ return GetNameForElement(kind)

def DartDefaultValue(field):

if field.default: