services/dart/lib/src/service_provider.dart - Issue 816113004: Dart: Adds a content handler and a test.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/dart/lib/src/service_provider.dart

Issue 816113004: Dart: Adds a content handler and a test. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 part of application;

	6

	7 typedef bindings.Interface InterfaceFactory(

	8 core.MojoMessagePipeEndpoint endpoint);

	9

	10 class ServiceProvider implements service_provider.ServiceProviderInterface {

	11 InterfaceFactory _interfaceFactory;

	12

	13 ServiceProvider(this._interfaceFactory);

	14

	15 connectToService(String interfaceName, core.MojoMessagePipeEndpoint pipe) {

	16 var interfaceImpl = _interfaceFactory(pipe);

	17 interfaceImpl.listen();

	18 }

	19 }
	abarth-chromium 2015/01/18 22:19:02 I'm not sure why we need this code. Why isn't thi I'm not sure why we need this code. Why isn't this code just generated from the mojom for ServiceProvider? zra 2015/01/20 17:36:51 The message pipe handle in the mojom doesn't (and Show quoted text On 2015/01/18 22:19:02, abarth wrote: > I'm not sure why we need this code. Why isn't this code just generated from the > mojom for ServiceProvider? The message pipe handle in the mojom doesn't (and can't, I think) have a more specific type. Instead, the type the handle should have is taken from the factory closure passed to the constructor. I'm not sure whether I should generate code to do this for every message pipe handle in a mojom.
OLD	NEW