mojo/public/dart/bindings.dart - Issue 816113004: Dart: Adds a content handler and a test.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/dart/bindings.dart

Issue 816113004: Dart: Adds a content handler and a test. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Merge CLs that address comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 library bindings;	5 library bindings;

6	6

7 import 'dart:async';	7 import 'dart:async';

8 import 'dart:convert';	8 import 'dart:convert';

9 import 'dart:mirrors';	9 import 'dart:mirrors';

10 import 'dart:mojo_core' as core;	10 import 'dart:mojo_core' as core;

11 import 'dart:typed_data';	11 import 'dart:typed_data';

12	12

	13 import 'package:mojo/public/interfaces/application/application.mojom.dart' as ap plication;

	14 import 'package:mojo/public/interfaces/application/service_provider.mojom.dart' as service_provider;

	15 import 'package:mojo/public/interfaces/application/shell.mojom.dart' as shell;
	abarth-chromium 2015/01/16 05:43:43 This is a bit of a layering violation. The code i This is a bit of a layering violation. The code in mojo/public/dart shouldn't know anything about applications, service providers, or shells. Those are concepts built up on top of the underlying language buildings. In principle, you could build a completely different set of services and conventions on top of the language bindings. Instead, these concepts belong in the dart_content_handler, which is the layer of the system that starts understanding the constellation of services that exist. zra 2015/01/16 17:54:51 Moved to an application library under //services/d Show quoted text On 2015/01/16 05:43:43, abarth wrote: > This is a bit of a layering violation. The code in mojo/public/dart shouldn't > know anything about applications, service providers, or shells. Those are > concepts built up on top of the underlying language buildings. In principle, > you could build a completely different set of services and conventions on top of > the language bindings. > > Instead, these concepts belong in the dart_content_handler, which is the layer > of the system that starts understanding the constellation of services that > exist. Moved to an application library under //services/dart/
	16

	17 part 'src/application.dart';

13 part 'src/client.dart';	18 part 'src/client.dart';

14 part 'src/codec.dart';	19 part 'src/codec.dart';

15 part 'src/interface.dart';	20 part 'src/interface.dart';

16 part 'src/message.dart';	21 part 'src/message.dart';

	22 part 'src/service_provider.dart';

17 part 'src/struct.dart';	23 part 'src/struct.dart';

OLD	NEW

« mojo/dart/embedder/dart_controller.cc ('K') | « mojo/dart/embedder/test/dart_to_cpp_tests.dart ('k') | mojo/public/dart/core.dart » ('j') | mojo/public/dart/src/application.dart » ('J')