Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 816113003: Instrumenting WindowImpl::WndProc to find jank (Closed)

Created:
6 years ago by vadimt
Modified:
6 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumenting WindowImpl::WndProc to find jank Prior instrumentations didn't catch the jank, i.e. most jank is inside "440919 <<MessagePumpForUI::ProcessNextWindowsMessage>>", but outside of other instrumentations. This means that the places I suspected are sources of jank actually aren't. Widening the search. BUG=440919 Committed: https://crrev.com/fa84141823aeaad1c993d6eb24975df6fdc8017f Cr-Commit-Position: refs/heads/master@{#309457}

Patch Set 1 #

Total comments: 2

Patch Set 2 : cpu@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/gfx/win/window_impl.cc View 1 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vadimt
cpu@, please review
6 years ago (2014-12-19 22:34:08 UTC) #2
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/816113003/diff/1/ui/gfx/win/window_impl.cc File ui/gfx/win/window_impl.cc (right): https://codereview.chromium.org/816113003/diff/1/ui/gfx/win/window_impl.cc#newcode288 ui/gfx/win/window_impl.cc:288: shouldn't be that lines 285-288 moved to 304 ?
6 years ago (2014-12-20 00:51:07 UTC) #3
vadimt
https://codereview.chromium.org/816113003/diff/1/ui/gfx/win/window_impl.cc File ui/gfx/win/window_impl.cc (right): https://codereview.chromium.org/816113003/diff/1/ui/gfx/win/window_impl.cc#newcode288 ui/gfx/win/window_impl.cc:288: Done; this is more efficient. FYI, semantically, there is ...
6 years ago (2014-12-20 01:02:14 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
6 years ago (2014-12-22 19:22:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816113003/20001
6 years ago (2014-12-22 19:24:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-22 20:32:25 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-22 20:33:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa84141823aeaad1c993d6eb24975df6fdc8017f
Cr-Commit-Position: refs/heads/master@{#309457}

Powered by Google App Engine
This is Rietveld 408576698