Issue 816103003: fix for valgrind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 816103003: fix for valgrind (Closed)

Created:
5 years, 12 months ago by joshua.litt

Modified:
5 years, 12 months ago

Reviewers:
jvanverth1, joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 5 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	src/gpu/GrBitmapTextContext.cpp	View	1	3 chunks	+9 lines, -10 lines	0 comments	Download

Total messages: 6 (2 generated)

joshualitt

This small fix avoids using an uninitialized variable by always inverting the view matrix. Its ...

5 years, 12 months ago (2014-12-23 15:39:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816103003/20001

5 years, 12 months ago (2014-12-23 15:48:26 UTC) #5

commit-bot: I haz the power

5 years, 12 months ago (2014-12-23 15:58:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/73483d9fbec9cfd1fd79e2cb8c255a22898d3743