chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js - Issue 816093002: Support alert nodes by introducing $descendant and !ttsProps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

Issue 816093002: Support alert nodes by introducing $descendant and !ttsProps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Simplify Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

index c14c6a92245c8b811bbc82985f75e4d9c37c3f15..3e6fe190fc10822c5f1432f83c733bacbed0718c 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

@@ -55,9 +55,11 @@ AutomationPredicate.link =

* @return {boolean}

AutomationPredicate.leaf = function(node) {

- return !node.firstChild || node.children.every(function(n) {

- return n.state.invisible;

- });

+ return !node.firstChild ||

+ node.role == chrome.automation.RoleType.button ||

+ node.children.every(function(n) {

+ return n.state.invisible;

+ });

};

/**