Send UMA stability stats in a separate UMA log on startup.

chrome/common/metrics/metrics_log_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/metrics/metrics_log_manager.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 99 matching lines @@
   EXPECT_EQ(ongoing_log, log_manager.current_log());
 
   EXPECT_FALSE(log_manager.has_staged_log());
   log_manager.StageNextLogForUpload();
   log_manager.DiscardStagedLog();
   EXPECT_FALSE(log_manager.has_unsent_logs());
 }
 
 TEST(MetricsLogManagerTest, InterjectedLogPreservesType) {
   MetricsLogManager log_manager;
+  DummyLogSerializer* serializer = new DummyLogSerializer;
+  log_manager.set_log_serializer(serializer);
+  log_manager.LoadPersistedUnsentLogs();
 
   MetricsLogBase* ongoing_log = new MetricsLogBase("id", 0, "version");
   MetricsLogBase* temp_log = new MetricsLogBase("id", 0, "version");
 
   log_manager.BeginLoggingWithLog(ongoing_log, MetricsLogBase::ONGOING_LOG);
   log_manager.PauseCurrentLog();
   log_manager.BeginLoggingWithLog(temp_log, MetricsLogBase::INITIAL_LOG);
   log_manager.FinishCurrentLog();
   log_manager.ResumePausedLog();
   log_manager.StageNextLogForUpload();
   log_manager.DiscardStagedLog();
 
   // Verify that the remaining log (which is the original ongoing log) still
   // has the right type.
-  DummyLogSerializer* serializer = new DummyLogSerializer;
-  log_manager.set_log_serializer(serializer);
   log_manager.FinishCurrentLog();
   log_manager.PersistUnsentLogs();
   EXPECT_EQ(0U, serializer->TypeCount(MetricsLogBase::INITIAL_LOG));
   EXPECT_EQ(1U, serializer->TypeCount(MetricsLogBase::ONGOING_LOG));
 }
 
 TEST(MetricsLogManagerTest, StoreAndLoad) {
   std::vector<MetricsLogManager::SerializedLog> initial_logs;
   std::vector<MetricsLogManager::SerializedLog> ongoing_logs;
 
   // Set up some in-progress logging in a scoped log manager simulating the
   // leadup to quitting, then persist as would be done on quit.
   {
     MetricsLogManager log_manager;
     DummyLogSerializer* serializer = new DummyLogSerializer;
     log_manager.set_log_serializer(serializer);
+    log_manager.LoadPersistedUnsentLogs();
+
     // Simulate a log having already been unsent from a previous session.
     MetricsLogManager::SerializedLog log;
     std::string text = "proto";
     log.SwapLogText(&text);
     serializer->persisted_logs_[MetricsLogBase::ONGOING_LOG].push_back(log);
     EXPECT_FALSE(log_manager.has_unsent_logs());
     log_manager.LoadPersistedUnsentLogs();
     EXPECT_TRUE(log_manager.has_unsent_logs());
 
     MetricsLogBase* log1 = new MetricsLogBase("id", 0, "version");
@@ skipping 59 matching lines @@
     EXPECT_EQ(0U, serializer->TypeCount(MetricsLogBase::ONGOING_LOG));
   }
 }
 
 TEST(MetricsLogManagerTest, StoreStagedLogTypes) {
   // Ensure that types are preserved when storing staged logs.
   {
     MetricsLogManager log_manager;
     DummyLogSerializer* serializer = new DummyLogSerializer;
     log_manager.set_log_serializer(serializer);
+    log_manager.LoadPersistedUnsentLogs();
 
     MetricsLogBase* log = new MetricsLogBase("id", 0, "version");
     log_manager.BeginLoggingWithLog(log, MetricsLogBase::ONGOING_LOG);
     log_manager.FinishCurrentLog();
     log_manager.StageNextLogForUpload();
     log_manager.StoreStagedLogAsUnsent(MetricsLogManager::NORMAL_STORE);
     log_manager.PersistUnsentLogs();
 
     EXPECT_EQ(0U, serializer->TypeCount(MetricsLogBase::INITIAL_LOG));
     EXPECT_EQ(1U, serializer->TypeCount(MetricsLogBase::ONGOING_LOG));
   }
 
   {
     MetricsLogManager log_manager;
     DummyLogSerializer* serializer = new DummyLogSerializer;
     log_manager.set_log_serializer(serializer);
+    log_manager.LoadPersistedUnsentLogs();
 
     MetricsLogBase* log = new MetricsLogBase("id", 0, "version");
     log_manager.BeginLoggingWithLog(log, MetricsLogBase::INITIAL_LOG);
     log_manager.FinishCurrentLog();
     log_manager.StageNextLogForUpload();
     log_manager.StoreStagedLogAsUnsent(MetricsLogManager::NORMAL_STORE);
     log_manager.PersistUnsentLogs();
 
     EXPECT_EQ(1U, serializer->TypeCount(MetricsLogBase::INITIAL_LOG));
     EXPECT_EQ(0U, serializer->TypeCount(MetricsLogBase::ONGOING_LOG));
   }
 }
 
 TEST(MetricsLogManagerTest, LargeLogDiscarding) {
   MetricsLogManager log_manager;
   DummyLogSerializer* serializer = new DummyLogSerializer;
   log_manager.set_log_serializer(serializer);
+  log_manager.LoadPersistedUnsentLogs();
+
   // Set the size threshold very low, to verify that it's honored.
   log_manager.set_max_ongoing_log_store_size(1);
 
   MetricsLogBase* log1 = new MetricsLogBase("id", 0, "version");
   MetricsLogBase* log2 = new MetricsLogBase("id", 0, "version");
   log_manager.BeginLoggingWithLog(log1, MetricsLogBase::INITIAL_LOG);
   log_manager.FinishCurrentLog();
   log_manager.BeginLoggingWithLog(log2, MetricsLogBase::ONGOING_LOG);
   log_manager.FinishCurrentLog();
 
   // Only the ongoing log should be written out, due to the threshold.
   log_manager.PersistUnsentLogs();
   EXPECT_EQ(1U, serializer->TypeCount(MetricsLogBase::INITIAL_LOG));
   EXPECT_EQ(0U, serializer->TypeCount(MetricsLogBase::ONGOING_LOG));
 }
 
 TEST(MetricsLogManagerTest, ProvisionalStoreStandardFlow) {
   // Ensure that provisional store works, and discards the correct log.
   {
     MetricsLogManager log_manager;
+    DummyLogSerializer* serializer = new DummyLogSerializer;
+    log_manager.set_log_serializer(serializer);
+    log_manager.LoadPersistedUnsentLogs();
+
     MetricsLogBase* log1 = new MetricsLogBase("id", 0, "version");
     MetricsLogBase* log2 = new MetricsLogBase("id", 0, "version");
     log_manager.BeginLoggingWithLog(log1, MetricsLogBase::INITIAL_LOG);
     log_manager.FinishCurrentLog();
     log_manager.BeginLoggingWithLog(log2, MetricsLogBase::ONGOING_LOG);
     log_manager.StageNextLogForUpload();
     log_manager.StoreStagedLogAsUnsent(MetricsLogManager::PROVISIONAL_STORE);
     log_manager.FinishCurrentLog();
     log_manager.DiscardLastProvisionalStore();
 
-    DummyLogSerializer* serializer = new DummyLogSerializer;
-    log_manager.set_log_serializer(serializer);
     log_manager.PersistUnsentLogs();
     EXPECT_EQ(0U, serializer->TypeCount(MetricsLogBase::INITIAL_LOG));
     EXPECT_EQ(1U, serializer->TypeCount(MetricsLogBase::ONGOING_LOG));
   }
 }
 
 TEST(MetricsLogManagerTest, ProvisionalStoreNoop) {
   // Ensure that trying to drop a sent log is a no-op, even if another log has
   // since been staged.
   {
     MetricsLogManager log_manager;
+    DummyLogSerializer* serializer = new DummyLogSerializer;
+    log_manager.set_log_serializer(serializer);
+    log_manager.LoadPersistedUnsentLogs();
+
     MetricsLogBase* log1 = new MetricsLogBase("id", 0, "version");
     MetricsLogBase* log2 = new MetricsLogBase("id", 0, "version");
     log_manager.BeginLoggingWithLog(log1, MetricsLogBase::ONGOING_LOG);
     log_manager.FinishCurrentLog();
     log_manager.StageNextLogForUpload();
     log_manager.StoreStagedLogAsUnsent(MetricsLogManager::PROVISIONAL_STORE);
     log_manager.StageNextLogForUpload();
     log_manager.DiscardStagedLog();
     log_manager.BeginLoggingWithLog(log2, MetricsLogBase::ONGOING_LOG);
     log_manager.FinishCurrentLog();
     log_manager.StageNextLogForUpload();
     log_manager.StoreStagedLogAsUnsent(MetricsLogManager::NORMAL_STORE);
     log_manager.DiscardLastProvisionalStore();
 
-    DummyLogSerializer* serializer = new DummyLogSerializer;
-    log_manager.set_log_serializer(serializer);
     log_manager.PersistUnsentLogs();
     EXPECT_EQ(1U, serializer->TypeCount(MetricsLogBase::ONGOING_LOG));
   }
 
   // Ensure that trying to drop more than once is a no-op
   {
     MetricsLogManager log_manager;
+    DummyLogSerializer* serializer = new DummyLogSerializer;
+    log_manager.set_log_serializer(serializer);
+    log_manager.LoadPersistedUnsentLogs();
+
     MetricsLogBase* log1 = new MetricsLogBase("id", 0, "version");
     MetricsLogBase* log2 = new MetricsLogBase("id", 0, "version");
     log_manager.BeginLoggingWithLog(log1, MetricsLogBase::ONGOING_LOG);
     log_manager.FinishCurrentLog();
     log_manager.StageNextLogForUpload();
     log_manager.StoreStagedLogAsUnsent(MetricsLogManager::NORMAL_STORE);
     log_manager.BeginLoggingWithLog(log2, MetricsLogBase::ONGOING_LOG);
     log_manager.FinishCurrentLog();
     log_manager.StageNextLogForUpload();
     log_manager.StoreStagedLogAsUnsent(MetricsLogManager::PROVISIONAL_STORE);
     log_manager.DiscardLastProvisionalStore();
     log_manager.DiscardLastProvisionalStore();
 
-    DummyLogSerializer* serializer = new DummyLogSerializer;
-    log_manager.set_log_serializer(serializer);
     log_manager.PersistUnsentLogs();
     EXPECT_EQ(1U, serializer->TypeCount(MetricsLogBase::ONGOING_LOG));
   }
 }
 
 TEST(MetricsLogManagerTest, SerializedLog) {
   const char kFooText[] = "foo";
   const std::string foo_hash = base::SHA1HashString(kFooText);
   const char kBarText[] = "bar";
   const std::string bar_hash = base::SHA1HashString(kBarText);
@@ skipping 25 matching lines @@
   foo = kFooText;
   log2.SwapLogText(&foo);
   log.Swap(&log2);
   EXPECT_FALSE(log.IsEmpty());
   EXPECT_EQ(kFooText, log.log_text());
   EXPECT_EQ(foo_hash, log.log_hash());
   EXPECT_TRUE(log2.IsEmpty());
   EXPECT_TRUE(log2.log_text().empty());
   EXPECT_TRUE(log2.log_hash().empty());
 }