Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 816013002: Use ShortPrint() in --trace_deopt output. (Closed)

Created:
6 years ago by bnoordhuis
Modified:
5 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Visibility:
Public.

Description

Print the SharedFunctionInfo besides the function name, makes matching against --trace_opt output easier. R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/6fff5880e3225c28706832ef81aec6b8c5a761f5

Patch Set 1 #

Patch Set 2 : Use ShortPrint() in --trace_deopt output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M src/deoptimizer.cc View 1 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bnoordhuis
6 years ago (2014-12-19 16:18:38 UTC) #2
bnoordhuis
Print the SharedFunctionInfo besides the function name, makes matching against --trace_opt output easier.
6 years ago (2014-12-19 19:47:20 UTC) #3
Sven Panne
lgtm
5 years, 11 months ago (2015-01-07 07:46:30 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 11 months ago (2015-01-07 07:48:58 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6fff5880e3225c28706832ef81aec6b8c5a761f5 Cr-Commit-Position: refs/heads/master@{#25962}
5 years, 11 months ago (2015-01-07 08:14:41 UTC) #8
Sven Panne
5 years, 11 months ago (2015-01-07 08:15:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6fff5880e3225c28706832ef81aec6b8c5a761f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698