Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 816003002: Add device space skshader GM to test kDevice_GrCoordSet (Closed)

Created:
6 years ago by bsalomon
Modified:
5 years, 11 months ago
Reviewers:
joshualitt, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@kpos
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add device space skshader GM to test kDevice_GrCoordSet Committed: https://skia.googlesource.com/skia/+/b0ae649b7ebda86ef53bf913798b809d500973ed

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : update #

Total comments: 2

Patch Set 4 : Add perspective #

Patch Set 5 : rebase #

Patch Set 6 : add virtual ~ to Prim class #

Patch Set 7 : add #if SK_SUPPORT_GPU, make FP a non-local class so it can be a template param in c++03. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -24 lines) Patch
A gm/dcshader.cpp View 1 2 3 4 5 6 1 chunk +298 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrColor.h View 1 2 3 4 2 chunks +12 lines, -2 lines 0 comments Download
M src/core/SkBlitter.cpp View 3 chunks +17 lines, -19 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
bsalomon
reed@ for the blitter changes.
6 years ago (2014-12-22 22:24:34 UTC) #2
joshualitt
On 2014/12/22 22:24:34, bsalomon wrote: > reed@ for the blitter changes. lgtm
6 years ago (2014-12-23 02:27:59 UTC) #3
joshualitt
actually, one nit and one comment https://codereview.chromium.org/816003002/diff/40001/gm/dcshader.cpp File gm/dcshader.cpp (right): https://codereview.chromium.org/816003002/diff/40001/gm/dcshader.cpp#newcode206 gm/dcshader.cpp:206: SkDebugf("Could not find ...
6 years ago (2014-12-23 02:31:51 UTC) #4
bsalomon
I added a perspective device coord matrix and updated the shader to use ensureFSCoords2D() to ...
5 years, 12 months ago (2014-12-23 20:34:23 UTC) #5
joshualitt
On 2014/12/23 20:34:23, bsalomon wrote: > I added a perspective device coord matrix and updated ...
5 years, 12 months ago (2014-12-23 20:37:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816003002/80001
5 years, 11 months ago (2014-12-29 14:13:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1365)
5 years, 11 months ago (2014-12-29 14:15:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816003002/100001
5 years, 11 months ago (2014-12-29 14:46:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1367)
5 years, 11 months ago (2014-12-29 14:47:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816003002/120001
5 years, 11 months ago (2014-12-29 14:56:04 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2014-12-29 15:05:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/b0ae649b7ebda86ef53bf913798b809d500973ed

Powered by Google App Engine
This is Rietveld 408576698