Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 815993002: Add GN files for ui/platform_window/win. (Closed)

Created:
6 years ago by Slava Chigrin
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GN files for ui/platform_window/win. Committed: https://crrev.com/ac0495771eeca2f2682b2cd879da2d47b19e00d2 Cr-Commit-Position: refs/heads/master@{#309377}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix sort order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M ui/aura/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
A + ui/platform_window/win/BUILD.gn View 1 chunk +12 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Slava Chigrin
https://codereview.chromium.org/815993002/diff/1/ui/platform_window/win/BUILD.gn File ui/platform_window/win/BUILD.gn (right): https://codereview.chromium.org/815993002/diff/1/ui/platform_window/win/BUILD.gn#newcode5 ui/platform_window/win/BUILD.gn:5: component("win_window") { Seems, Rietvield mistakely thinks that this file ...
6 years ago (2014-12-19 13:53:55 UTC) #2
sadrul
lgtm https://codereview.chromium.org/815993002/diff/1/ui/aura/BUILD.gn File ui/aura/BUILD.gn (right): https://codereview.chromium.org/815993002/diff/1/ui/aura/BUILD.gn#newcode127 ui/aura/BUILD.gn:127: "//ipc", sort
6 years ago (2014-12-19 21:51:10 UTC) #3
Slava Chigrin
https://codereview.chromium.org/815993002/diff/1/ui/aura/BUILD.gn File ui/aura/BUILD.gn (right): https://codereview.chromium.org/815993002/diff/1/ui/aura/BUILD.gn#newcode127 ui/aura/BUILD.gn:127: "//ipc", On 2014/12/19 21:51:10, sadrul wrote: > sort Done.
6 years ago (2014-12-21 15:53:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815993002/20001
6 years ago (2014-12-21 15:53:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-21 16:48:08 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-21 16:48:48 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ac0495771eeca2f2682b2cd879da2d47b19e00d2
Cr-Commit-Position: refs/heads/master@{#309377}

Powered by Google App Engine
This is Rietveld 408576698