Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: chrome/browser/thumbnails/thumbnail_service_unittest.cc

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extra inclusion from testing_profile.h Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/thumbnails/thumbnail_service_impl.cc ('k') | chrome/browser/ui/app_list/test/fake_profile.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/thumbnails/thumbnail_service_unittest.cc
diff --git a/chrome/browser/thumbnails/thumbnail_service_unittest.cc b/chrome/browser/thumbnails/thumbnail_service_unittest.cc
index 32f564c37a3a8b9050ace37b824873a55f2f528f..7b870f8fb887a337b3ed154da273ccca15b3dd6f 100644
--- a/chrome/browser/thumbnails/thumbnail_service_unittest.cc
+++ b/chrome/browser/thumbnails/thumbnail_service_unittest.cc
@@ -5,20 +5,21 @@
#include "chrome/browser/thumbnails/thumbnail_service_impl.h"
#include "base/memory/ref_counted.h"
+#include "chrome/browser/history/top_sites_factory.h"
#include "chrome/browser/history/top_sites_impl.h"
#include "chrome/test/base/testing_profile.h"
#include "testing/gtest/include/gtest/gtest.h"
typedef testing::Test ThumbnailServiceTest;
+namespace {
+
// A mock version of TopSitesImpl, used for testing
// ShouldAcquirePageThumbnail().
class MockTopSites : public history::TopSitesImpl {
public:
explicit MockTopSites(Profile* profile)
- : history::TopSitesImpl(profile),
- capacity_(1) {
- }
+ : history::TopSitesImpl(profile), capacity_(1) {}
// history::TopSitesImpl overrides.
bool IsNonForcedFull() override { return known_url_map_.size() >= capacity_; }
@@ -51,24 +52,33 @@ class MockTopSites : public history::TopSitesImpl {
DISALLOW_COPY_AND_ASSIGN(MockTopSites);
};
+// Testing factory that build a |MockTopSites| instance.
+scoped_refptr<RefcountedKeyedService> BuildMockTopSites(
+ content::BrowserContext* profile) {
+ return scoped_refptr<RefcountedKeyedService>(
+ new MockTopSites(static_cast<Profile*>(profile)));
+}
+
// A mock version of TestingProfile holds MockTopSites.
class MockProfile : public TestingProfile {
public:
- MockProfile() : mock_top_sites_(new MockTopSites(this)) {
+ MockProfile() {
+ TopSitesFactory::GetInstance()->SetTestingFactory(this, BuildMockTopSites);
}
- history::TopSites* GetTopSites() override { return mock_top_sites_.get(); }
-
void AddKnownURL(const GURL& url, const ThumbnailScore& score) {
- mock_top_sites_->AddKnownURL(url, score);
+ scoped_refptr<history::TopSites> top_sites =
+ TopSitesFactory::GetForProfile(this);
+ static_cast<MockTopSites*>(top_sites.get())->AddKnownURL(url, score);
}
private:
- scoped_refptr<MockTopSites> mock_top_sites_;
DISALLOW_COPY_AND_ASSIGN(MockProfile);
};
+} // namespace
+
TEST_F(ThumbnailServiceTest, ShouldUpdateThumbnail) {
const GURL kGoodURL("http://www.google.com/");
const GURL kBadURL("chrome://newtab");
@@ -94,7 +104,9 @@ TEST_F(ThumbnailServiceTest, ShouldUpdateThumbnail) {
ThumbnailScore bad_score;
bad_score.time_at_snapshot = base::Time::UnixEpoch(); // Ancient time stamp.
profile.AddKnownURL(kGoodURL, bad_score);
- ASSERT_TRUE(profile.GetTopSites()->IsNonForcedFull());
+ scoped_refptr<history::TopSites> top_sites =
+ TopSitesFactory::GetForProfile(&profile);
+ ASSERT_TRUE(top_sites->IsNonForcedFull());
// Should be false, as the top sites data is full, and the new URL is
// not known.
« no previous file with comments | « chrome/browser/thumbnails/thumbnail_service_impl.cc ('k') | chrome/browser/ui/app_list/test/fake_profile.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698