Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: chrome/browser/history/top_sites.h

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extra inclusion from testing_profile.h Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/top_sites.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/top_sites.h
diff --git a/chrome/browser/history/top_sites.h b/chrome/browser/history/top_sites.h
index 6fa5826ca1d16f0172e54f3c31344a59b589516b..03589366fdc7df404a0d872f85c424ed518df3c1 100644
--- a/chrome/browser/history/top_sites.h
+++ b/chrome/browser/history/top_sites.h
@@ -8,12 +8,12 @@
#include "base/basictypes.h"
#include "base/callback.h"
#include "base/gtest_prod_util.h"
-#include "base/memory/ref_counted.h"
#include "base/observer_list.h"
#include "base/task/cancelable_task_tracker.h"
#include "components/history/core/browser/history_types.h"
#include "components/history/core/browser/top_sites_observer.h"
#include "components/history/core/common/thumbnail_score.h"
+#include "components/keyed_service/core/refcounted_keyed_service.h"
#include "content/public/browser/notification_observer.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/image/image.h"
@@ -37,15 +37,11 @@ class TopSitesCache;
//
// Some methods should only be called from the UI thread (see method
// descriptions below). All others are assumed to be threadsafe.
-class TopSites
- : public base::RefCountedThreadSafe<TopSites>,
- public content::NotificationObserver {
+class TopSites : public RefcountedKeyedService,
+ public content::NotificationObserver {
public:
TopSites();
- // Initializes TopSites.
- static TopSites* Create(Profile* profile, const base::FilePath& db_name);
-
// Sets the given thumbnail for the given URL. Returns true if the thumbnail
// was updated. False means either the URL wasn't known to us, or we felt
// that our current thumbnail was superior to the given one. Should be called
@@ -119,9 +115,6 @@ class TopSites
// Clear the blacklist. Should be called from the UI thread.
virtual void ClearBlacklistedURLs() = 0;
- // Shuts down top sites.
- virtual void Shutdown() = 0;
-
// Query history service for the list of available thumbnails. Returns the
// task id for the request, or |base::CancelableTaskTracker::kBadTaskId| if a
// request could not be made. Public only for testing purposes.
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/top_sites.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698