chrome/browser/extensions/api/top_sites/top_sites_apitest.cc - Issue 815983002: Topsites become keyedService based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/top_sites/top_sites_apitest.cc

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove extra inclusion from testing_profile.h Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/top_sites/top_sites_apitest.cc

diff --git a/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc b/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc

index 0cb64275faa4f4c562827c27ee721dcbbec7cd14..d1e36b8c591c763b1e487d49660b4c3598e2dcf9 100644

--- a/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc

+++ b/chrome/browser/extensions/api/top_sites/top_sites_apitest.cc

@@ -7,6 +7,7 @@

#include "chrome/browser/extensions/api/top_sites/top_sites_api.h"

#include "chrome/browser/extensions/extension_function_test_utils.h"

#include "chrome/browser/history/top_sites.h"

+#include "chrome/browser/history/top_sites_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/test/base/in_process_browser_test.h"

@@ -23,7 +24,8 @@ class TopSitesExtensionTest : public InProcessBrowserTest {

}

void SetUpOnMainThread() override {

- history::TopSites* top_sites = browser()->profile()->GetTopSites();

+ scoped_refptr<history::TopSites> top_sites =

+ TopSitesFactory::GetForProfile(browser()->profile());

// This may return async or sync. If sync, top_sites_inited_ will be true

// before we get to the conditional below. Otherwise, we'll run a nested