chrome/browser/devtools/chrome_devtools_manager_delegate.cc - Issue 815983002: Topsites become keyedService based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

Issue 815983002: Topsites become keyedService based. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove extra inclusion from testing_profile.h Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/chrome_devtools_manager_delegate.cc

diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc

index 1bd1a82de58568b078d166c01d023bd8cefad46f..e9339223533afb0b4c384c5a19559182e0207c5f 100644

--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc

+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.cc

@@ -8,6 +8,7 @@

#include "chrome/browser/devtools/devtools_target_impl.h"

#include "chrome/browser/devtools/devtools_window.h"

#include "chrome/browser/history/top_sites.h"

+#include "chrome/browser/history/top_sites_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/browser.h"

@@ -50,7 +51,8 @@ std::string ChromeDevToolsManagerDelegate::GetPageThumbnailData(

const GURL& url) {

for (chrome::BrowserIterator it; !it.done(); it.Next()) {

Profile* profile = (*it)->profile();

- history::TopSites* top_sites = profile->GetTopSites();

+ scoped_refptr<history::TopSites> top_sites =

+ TopSitesFactory::GetForProfile(profile);

if (!top_sites)

continue;

scoped_refptr<base::RefCountedMemory> data;